Conversation
|
screenshot / tested with banana rpi-4
|
rmandrad
changed the title
systemcrash
added
the
depends on PR in other repo
The forked luci project contains a patch [1] that will enable BE standard. [1] - openwrt/luci#7279
|
the below are now released RPCD - openwrt/rpcd#5 |
|
@hnyman would you mind to have a look at this pr? both the RPCD and iwinfo PRs have been committed. thank you |
What do you mean, 'released'?
|
yes those dependent PRs have been merged |
merged.... where? |
The forked luci project contains a patch [1] that will enable BE standard. [1] - openwrt/luci#7279 (cherry picked from commit 4d65ad8)
|
Ah, OK. I see now. That was confusing because your linked PRs were/are not merged. |
yes I was confused also ... but it got there eventually somehow ;) |
|
You should also update --- a/modules/luci-base/htdocs/luci-static/resources/network.js
+++ b/modules/luci-base/htdocs/luci-static/resources/network.js
@@ -3396,6 +3396,11 @@ WifiDevice = baseclass.extend(/** @lends LuCI.network.WifiDevice.prototype */ {
* - `HE40` - applicable to IEEE 802.11ax, 40 MHz wide channels
* - `HE80` - applicable to IEEE 802.11ax, 80 MHz wide channels
* - `HE160` - applicable to IEEE 802.11ax, 160 MHz wide channels
+ * - `EHT20` - applicable to IEEE 802.11be, 20 MHz wide channels
+ * - `EHT40` - applicable to IEEE 802.11be, 40 MHz wide channels
+ * - `EHT80` - applicable to IEEE 802.11be, 80 MHz wide channels
+ * - `EHT160` - applicable to IEEE 802.11be, 160 MHz wide channels
+ * - `EHT320` - applicable to IEEE 802.11be, 320 MHz wide channels
*/
getHTModes: function() {
var htmodes = this.ubus('dev', 'iwinfo', 'htmodes'); |
rmandrad
force-pushed
the
11be
branch
3 times, most recently
from
b9c2e75 to
8b741d1
Compare
|
@systemcrash @dannil no problems to date on my end ... and good feedback on the forum Is there anything you need in order to approve this ? |
The formatting is still not correct, I'd at least want that fixed (and it seems that your previous fixed ones has returned as well in some cases), I took some screenshots to show you, it's basically the entire file it's happened in so not worth commenting every single instance. Turn off any automatic formatting you have in your editor and only include your changes. It makes it very hard to review the PR since a lot of things you haven't directly changed is showing up in the diff.
|
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
|
I concur with @dannil on this one. Where code has not changed, leave indentation untouched. |
Tested with banana rpi-4 In order to complete 11be support - the below pulls will need to be applied RPCD - openwrt/rpcd#5 iwinfo - openwrt/iwinfo#10 Signed-off-by: Rudy Andram <rmandrad@gmail.com> Tested-By: Daniel Pawlik <pawlik.dan@gmail.com>
|
I will close this pull ... as I don't see any issues from my side ... it seems to only happen when integrating it here |
|
why have you close it @rmandrad ? I agree with the devs, the idention is wrong and it is not a first file that got such issue. |
|
I opened a new pull - #7302 hopefully clearing out all of the spaces/tabs previous updates etc |
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
The feed repo contains a patch [1]. [1] openwrt/luci#7279 (cherry picked from commit 016c0d0)
|
Dear all, @rmandrad, @systemcrash, @dannil, @danpawlik, @hnyman, There is a new PR linked to 11be done by @prokowsoftware here: Can you look? Thanks in advance. |
6 participants
Add 11be support
Tested with banana rpi-4
In order to complete 11be support - the below pulls will need to be applied
RPCD - openwrt/rpcd#5
iwinfo - openwrt/iwinfo#10
Signed-off-by: Rudy Andram rmandrad@gmail.com
Tested-By: Daniel Pawlik pawlik.dan@gmail.com