luci-mod-status: move getConntrackList from ubus to fs.exec#8490
luci-mod-status: move getConntrackList from ubus to fs.exec#8490jjm2473 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This is test on 24.10.5. |
This comment has been minimized.
This comment has been minimized.
bc970ea to
55930d1
Compare
|
[v2]:
Link to v1: jjm2473@bc970ea |
55930d1 to
8c72760
Compare
8c72760 to
2a484cc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
That's a good idea, I like it. I just wonder if it would be better to have a dedicated backend route which takes care of the parsing and spits out a JSON for the front end to consume instead of parsing the raw system files in the frontend code directly. |
|
LGTM |
|
In fact, modern browsers generally outperform routers, so it might be more appropriate to perform the main computation in the browser? |
2a484cc to
f80986d
Compare
This comment has been minimized.
This comment has been minimized.
to prevent procd from being kicked off by ubusd due to large amounts of data. See openwrt/openwrt#9747 Fixes openwrt#6360 Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
f80986d to
eb3d445
Compare
|
[v3]:
Link to v2: jjm2473@f80986d |
There was a problem hiding this comment.
Can we rename this to e.g. luci-status-conntrack-call?
There was a problem hiding this comment.
@systemcrash
Perhaps in the future, Luci will need to bypass ubusd when reading other data. In that case, this can be written to this file, and the first parameter, action, can define new actions. If this extensibility is not needed, I can also rename the file to luci-status-conntrack-call as you mentioned and remove the parameter.



to prevent procd from being kicked off by ubusd
due to large amounts of data.
See openwrt/openwrt#9747
Fixes #6360
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the MakefileMove getConntrackList from ubus to web to prevent procd from being kicked off by ubusd due to large amounts of data.
Has been tested with a fake 5MB /proc/net/nf_conntrack, procd not kicked off (Such a large amount of data can actually cause browser lag.).
