luci-theme-bootstrap: update favicon/icon assets#8535
luci-theme-bootstrap: update favicon/icon assets#8535owlsy wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
I don't think there's enough contrast on a dark background. Perhaps add a white outline? |
|
I was thinking about it, and there is a way to have the SVG icon be modified if dark mode is used (source). So the plan is to have the default SVG as blue & dark blue, but if dark mode is being used, the SVG would change to white & blue. Images from style guide: For the PNG fallback, I should keep in mind the style guide preventing misuse, so I don't think I can use an outline (seen here). Considering most browsers support the SVG icon (except Safari macOS 15 and earlier, Safari iOS 18 and earlier, and Internet Explorer), we really shouldn't see the fallback PNG used regardless. It also looks like Safari will automatically add a white background to the PNG icon if it determines the contrast is too low. So, we should be covered. |
Automatic SVG iconThe SVG icon now automatically switches between a light mode/default variant and a dark mode variant. Will work for Chrome, Firefox, Edge, etc.
Note Safari at the moment ignores PNG icon fallbackYou will only ever see this on older versions of browsers, and Internet Explorer.
Additional changes to
|
80dc54a to
c8a8d6a
Compare
Current favicon and logo used per commit history on openwrt#6738 was copied directly from 'luci-theme-openwrt2020' and did not have the opportunity to use the 'blue & dark blue' favicon as per the openwrt/branding style guide, as the favicon folder uses this colour scheme, which the SVG is also able to provide. SVG icon now automatically switches between a light mode/default variant and a dark mode variant. Rearranged icon order so SVG is first, and PNG can be the fallback. Added apple-touch-icon, for iPadOS and iOS devices. The icon was already made in openwrt/branding, so no need to create a new one. Included in the commit. Added manifest.json file, for PWA and Android. Signed-off-by: Joshua Criss <owlsy@outlook.com.au>








Pull Request details
Description
The current favicon/icon assets used per commit history on #6738 was copied directly from 'luci-theme-openwrt2020' (commit source) and did not have the opportunity to use the 'blue & dark blue' logo as per the openwrt/branding style guide, as the
faviconfolder uses this colour scheme, which the SVG is also able to provide. Updated accordingly.Screenshot or video of changes (If applicable)
Maintainer (Preferred)
@jow-, @hnyman, @systemcrash, others
Tested on
OpenWrt version: OpenWrt 25.12.2 (r32802-f505120278)
LuCI version: LuCI openwrt-25.12 branch (26.097.47759~98acb68)
Web browser: Safari Version 26.5 (21624.2.1.11.1)
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.PKG_VERSIONin the Makefile. (Not applicable to themes)