Skip to content

luci-app-filemanager: auto sizing for file-list, dark mode support, other minor fixes#8546

Merged
systemcrash merged 1 commit intomasterfrom
unknown repository
Apr 16, 2026
Merged

luci-app-filemanager: auto sizing for file-list, dark mode support, other minor fixes#8546
systemcrash merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 12, 2026

Pull Request details

Description

  • Automatic width and height for the file-list window, automatic width for text editor, hex editor and help windows. Justification is that user can adjust width using browser window and allows responsive width to function. Removal of width user settings.
  • Added support for dark mode, previously was hard-coded for light mode and caused a conflict with using bootstrap which adapts to both modes.
  • Minor fixes to buttons, heading, nav bar, borders. Small style tidying, including:
    • File list shows alternating background colour on rows.
    • File Manager title no longer accidentally line-breaks.
    • Path bar now fluid.
    • Borders all fixed, parent directory table row resolved.
    • Tab buttons refined further.
    • Go button now a right arrow, to simplify use and reduce the need for translation.
  • Tested across all luci-themes, as a result:
    • Added fallback CSS if a theme does not have dark mode.
    • Enclosed most open CSS classes as it was affecting other elements outside of the file manager.
  • Closes luci-app-filemanager: flexible width, dark mode, refinements #8537, although I could not figure out how to automatically set file uploads' permissions from 600 to 644 automatically.

Video

luci.mp4

Screenshots

image image image image image image image image image image

Maintainer (Preferred)

Dmitry R, but I can't seem to find a GitHub account.
Pinging @systemcrash due to recent commits.


Tested on

OpenWrt version: OpenWrt 25.12.2 (r32802-f505120278)
LuCI version: LuCI openwrt-25.12 branch (26.100.49936~3cefdb7)
Web browser: Safari Version 26.5 (21624.2.2)


Checklist

  • This PR is not from my main or master branch 💩, but a separate branch. ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff).
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages.
  • (Optional) Includes what Issue it closes (e.g. openwrt/luci#issue-number).

@github-actions

This comment has been minimized.

@ghost ghost force-pushed the luci-app-filemanager-01 branch 3 times, most recently from 80525b1 to a10067a Compare April 12, 2026 23:24
@ghost ghost marked this pull request as draft April 13, 2026 09:57
@ghost ghost force-pushed the luci-app-filemanager-01 branch from a10067a to 9655f4f Compare April 13, 2026 09:59
@ghost ghost marked this pull request as ready for review April 13, 2026 09:59
@ghost ghost force-pushed the luci-app-filemanager-01 branch from 9655f4f to b36ddb9 Compare April 13, 2026 10:05
@ghost ghost force-pushed the luci-app-filemanager-01 branch from b36ddb9 to 3da976a Compare April 15, 2026 10:11
Automatic width and height for the file-list,
automatic width for text editor, hex editor
and help window. Justification is that user
can adjust width using browser window and
allows responsive width to function.
Added support for dark mode, previously
was hard-coded for light mode and caused
a visual conflict with using bootstrap which
adapts to both modes. Minor fixes to buttons,
heading, nav bar, borders. Small style tidying.
Further tested across all luci-themes. Added
fallback CSS if a theme does not have dark
mode, and enclosed most open CSS classes
such as .selected, as it was affecting other
elements outside of the file manager.

Closes #8537.

Signed-off-by: Joshua Criss <owlsy@outlook.com.au>
@ghost ghost force-pushed the luci-app-filemanager-01 branch from 3da976a to aec89ca Compare April 16, 2026 09:39
@systemcrash systemcrash merged commit 357f9fb into openwrt:master Apr 16, 2026
6 checks passed
@ghost ghost deleted the luci-app-filemanager-01 branch April 17, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

luci-app-filemanager: flexible width, dark mode, refinements

1 participant