ubus: fix truncated field in DHCPv6 lease query#383
Merged
openwrt-bot merged 1 commit intoopenwrt:masterfrom Mar 16, 2026
Merged
ubus: fix truncated field in DHCPv6 lease query#383openwrt-bot merged 1 commit intoopenwrt:masterfrom
openwrt-bot merged 1 commit intoopenwrt:masterfrom
Conversation
Noltari
approved these changes
Mar 16, 2026
The assigned_subnet_id field in struct dhcpv6_lease is uint32_t, not uint16_t. Unlikely to matter in practice, since the number of meaningful bits in the field is (assignment size) - (interface assignemt size), so largest typically be 64 - 48 = 16. But it is possible to assign a /32 to an interface in openwrt. Signed-off-by: Mark H. Spatz <mark.h.spatz@gmail.com> Link: openwrt#383 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Noltari
force-pushed
the
mspatz/fix_ubus_lease_query
branch
from
51c3cad to
b960d4c
Compare
Member
|
Merged, thanks @mmmspatz! |
Noltari
pushed a commit
to Noltari/odhcpd
that referenced
this pull request
Mar 16, 2026
The assigned_subnet_id field in struct dhcpv6_lease is uint32_t, not uint16_t. Unlikely to matter in practice, since the number of meaningful bits in the field is (assignment size) - (interface assignemt size), so largest typically be 64 - 48 = 16. But it is possible to assign a /32 to an interface in openwrt. (cherry picked from commit b960d4c) Signed-off-by: Mark H. Spatz <mark.h.spatz@gmail.com> Link: openwrt#383 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assigned_subnet_idfield instruct dhcpv6_leaseisuint32_t, notuint16_t.Unlikely to matter in practice, since the number of meaningful bits in the field is
(assignment size) - (interface assignemt size), so largest typically be64 - 48 = 16. But it is possible to assign a /32 to an interface in openwrt.