odhcpd: Ignore NULL in dhcpv4_free_lease() stub#384
Merged
openwrt-bot merged 1 commit intoopenwrt:masterfrom Mar 16, 2026
Merged
odhcpd: Ignore NULL in dhcpv4_free_lease() stub#384openwrt-bot merged 1 commit intoopenwrt:masterfrom
openwrt-bot merged 1 commit intoopenwrt:masterfrom
Conversation
mmmspatz
force-pushed
the
mspatz/dhcpv4_free_lease_stub_guard
branch
from
6d30361 to
7b76745
Compare
Contributor
Author
|
Oops, originally referenced the wrong issue. |
mmmspatz
force-pushed
the
mspatz/dhcpv4_free_lease_stub_guard
branch
from
7b76745 to
ea3d9f6
Compare
Noltari
approved these changes
Mar 16, 2026
When DHCPV4_SUPPORT is not defined, a stub implementation of dhcpv4_free_lease() is provided that logs an error when it's called. A couple sites in config.c unconditionally free the dhcpv4_lease field of struct lease_cfg, causing log spam like: | Trying to free IPv4 assignment 0x(nil) Silence by making the stub a noop if the argument is NULL, just like the actual implementation. Closes: openwrt#382 Signed-off-by: Mark H. Spatz <mark.h.spatz@gmail.com> Link: openwrt#384 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Noltari
force-pushed
the
mspatz/dhcpv4_free_lease_stub_guard
branch
from
ea3d9f6 to
2a316db
Compare
Member
|
Merged, thanks @mmmspatz! |
Noltari
pushed a commit
to Noltari/odhcpd
that referenced
this pull request
Mar 16, 2026
When DHCPV4_SUPPORT is not defined, a stub implementation of dhcpv4_free_lease() is provided that logs an error when it's called. A couple sites in config.c unconditionally free the dhcpv4_lease field of struct lease_cfg, causing log spam like: | Trying to free IPv4 assignment 0x(nil) Silence by making the stub a noop if the argument is NULL, just like the actual implementation. (cherry picked from commit 2a316db) Closes: openwrt#382 Signed-off-by: Mark H. Spatz <mark.h.spatz@gmail.com> Link: openwrt#384 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
DHCPV4_SUPPORTis not defined, a stub implementation ofdhcpv4_free_lease()is provided that logs an error when it's called. A couple sites in config.c unconditionally free thedhcpv4_leasefield ofstruct lease_cfg, causing log spam like:Silence by making the stub a noop if the argument is NULL, just like the actual implementation.
Fixes: #382