feat:add linux/arm64 support to Docker image - #466
Merged
Conversation
benoit74
self-requested a review
April 20, 2026 08:09
benoit74
requested changes
Apr 20, 2026
benoit74
left a comment
Collaborator
There was a problem hiding this comment.
Thank you!
Please:
- ensure we will run all tests in the CI on
arm64as well, we cannot afford to just hope it will not break in the future: you basically need to duplicate all jobs, and fix existing job names to make it clear they run onamd64. Github runner to use isubuntu-24.04-arm - add an entry in CHANGELOG.md
Contributor
Author
|
@benoit74 please check now.
|
benoit74
reviewed
Apr 20, 2026
| - Added Total playlist duration in the Playlist view and Playlist panel. (#435) | ||
| - Added `analyze_zim.py` contrib script to analyze video duration vs. file size correlation in ZIM files (#439) | ||
| - Bundle ZIM UI inside pip package (#459) | ||
| - Added `linux/arm64` support to Docker image and CI |
Collaborator
There was a problem hiding this comment.
Please mention issue number in parentheses
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=====================================
Coverage 0.90% 0.90%
=====================================
Files 11 11
Lines 1211 1211
Branches 166 166
=====================================
Hits 11 11
Misses 1200 1200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benoit74
requested changes
Apr 20, 2026
benoit74
left a comment
Collaborator
There was a problem hiding this comment.
Please fix comment and squash commits into one commit and I will merge
Abhijithmns
force-pushed
the
multi-arch-support
branch
from
April 20, 2026 11:56
2a7c8b7 to
e258e33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When pulling the Docker image on an
arm64machine,users get an
exec format errorbecause only alinux/amd64image is publishedto the registry. ARM64 users cannot run the tool at all.
Test
Tested ARM64 support locally using
docker buildx:linux/arm64@veritasium,--pagination=1,--low-quality)All Dockerfile components confirmed ARM64 compatible:
node:24-alpine,python:3.14-trixie— multi-arch base imagesffmpeg,wget,aria2— available on arm64 via aptdeno— official arm64 support via install scriptCloses #458