Skip to content

feat:add linux/arm64 support to Docker image - #466

Merged
benoit74 merged 1 commit into
openzim:mainfrom
Abhijithmns:multi-arch-support
Apr 20, 2026
Merged

feat:add linux/arm64 support to Docker image#466
benoit74 merged 1 commit into
openzim:mainfrom
Abhijithmns:multi-arch-support

Conversation

@Abhijithmns

Copy link
Copy Markdown
Contributor

Issue

When pulling the Docker image on an arm64 machine,
users get an exec format error because only a linux/amd64 image is published
to the registry. ARM64 users cannot run the tool at all.

Test

Tested ARM64 support locally using docker buildx:

  • Built the image successfully for linux/arm64
  • Ran the container with a real scrape (@veritasium, --pagination=1, --low-quality)
  • Video downloaded, formats merged, and re-encoding started without any architecture errors

All Dockerfile components confirmed ARM64 compatible:

  • node:24-alpine, python:3.14-trixie — multi-arch base images
  • ffmpeg, wget, aria2 — available on arm64 via apt
  • deno — official arm64 support via install script

Closes #458

@benoit74
benoit74 self-requested a review April 20, 2026 08:09

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please:

  • ensure we will run all tests in the CI on arm64 as well, we cannot afford to just hope it will not break in the future: you basically need to duplicate all jobs, and fix existing job names to make it clear they run on amd64. Github runner to use is ubuntu-24.04-arm
  • add an entry in CHANGELOG.md

@Abhijithmns

Copy link
Copy Markdown
Contributor Author

@benoit74 please check now.
I've made the requested changes:

  • Duplicated all CI jobs in Tests.yml and QA.yml to also run on ubuntu-24.04-arm
  • Added platforms: linux/amd64 linux/arm64 to both Publish.yml and PublishDockerDevImage.yml
  • Added entry in CHANGELOG.md

Comment thread CHANGELOG.md Outdated
- Added Total playlist duration in the Playlist view and Playlist panel. (#435)
- Added `analyze_zim.py` contrib script to analyze video duration vs. file size correlation in ZIM files (#439)
- Bundle ZIM UI inside pip package (#459)
- Added `linux/arm64` support to Docker image and CI

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention issue number in parentheses

@codecov

codecov Bot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.90%. Comparing base (bf2bb9a) to head (e258e33).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #466   +/-   ##
=====================================
  Coverage   0.90%   0.90%           
=====================================
  Files         11      11           
  Lines       1211    1211           
  Branches     166     166           
=====================================
  Hits          11      11           
  Misses      1200    1200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix comment and squash commits into one commit and I will merge

@benoit74
benoit74 merged commit e939644 into openzim:main Apr 20, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check/add support for arm64 Docker image

2 participants