express-http-proxy ^1.6.0 compatibility#462
Open
JeanBaptisteWATENBERG wants to merge 1 commit into
Open
Conversation
codefromthecrypt
left a comment
codefromthecrypt
left a comment
Member
There was a problem hiding this comment.
Thanks for the help.
I presume this means dropping support for earlier express. Is that something we should do?
Contributor
|
This is related to #151. |
Author
|
Hi, Indeed this is related to this issue. I met the same issue and decided to update the version. I was not aware of this GitHub issue. |
Contributor
|
@JeanBaptisteWATENBERG do you mind to rebase? |
JeanBaptisteWATENBERG
force-pushed
the
bump-express-http-proxy
branch
from
February 6, 2020 21:15
7d7adbf to
fc12db3
Compare
Author
|
rebase done |
|
Why is this not merged yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request add support for express-http-proxy ^1.6.0
Fixes #151