Skip to content

✨ OPRUN-4514: Address comments on 'Move Single Own Namespace back to alpha'#2569

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
tmshort:sons-tp2
Mar 17, 2026
Merged

✨ OPRUN-4514: Address comments on 'Move Single Own Namespace back to alpha'#2569
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
tmshort:sons-tp2

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Mar 16, 2026

Addresses comments made on #2568 (which merged wicked fast)

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings March 16, 2026 20:34
@netlify
Copy link

netlify bot commented Mar 16, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 77e4860
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69b86c17ab3ba90008e07ca5
😎 Deploy Preview https://deploy-preview-2569--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates demo scripts and documentation to reflect the current “standard vs experimental” manifest split and clarifies when the SingleOwnNamespaceInstallSupport feature-gate is required for webhook-enabled extensions.

Changes:

  • Demo cleanup now restores the standard feature set by applying manifests/standard.yaml instead of patching the operator-controller Deployment and applying a non-existent base.yaml.
  • Tutorials clarify that webhook-enabled extensions targeting SingleNamespace/OwnNamespace require the SingleOwnNamespaceInstallSupport feature-gate.
  • Draft how-to note clarifies the feature is alpha and disabled by default.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
hack/demo/single-namespace-demo-script.sh Simplifies cleanup by re-applying standard manifests to reset CRDs/deployments.
hack/demo/own-namespace-demo-script.sh Same cleanup reset approach using manifests/standard.yaml.
docs/tutorials/explore-available-content.md Clarifies feature-gate requirement for webhook installs targeting a single namespace.
docs/draft/tutorials/explore-available-content-metas-endpoint.md Same clarification for the metas endpoint tutorial draft.
docs/draft/howto/single-ownnamespace-install.md Improves wording about alpha status and default-disabled feature gate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Todd Short <tshort@redhat.com>
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.61%. Comparing base (e7a9611) to head (77e4860).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2569   +/-   ##
=======================================
  Coverage   68.61%   68.61%           
=======================================
  Files         131      131           
  Lines        9333     9333           
=======================================
  Hits         6404     6404           
  Misses       2438     2438           
  Partials      491      491           
Flag Coverage Δ
e2e 39.30% <ø> (+0.17%) ⬆️
experimental-e2e 51.62% <ø> (ø)
unit 53.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 55c29ef into operator-framework:main Mar 17, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants