Bug/COMMS-997: Include version changes in the "Only changes" activity filter

[akabiru]

https://community.openproject.org/wp/COMMS-997

Include version changes in the "Only changes" activity filter

Before: the journals that only set a target version or an observed-in version are missing under "Show changes only".

After: both journals are listed.

[Copilot]

🟢 Approval recommended

The change is narrowly scoped, uses existing side-table comparison logic consistently, and is backed by targeted specs covering the reported regression scenarios.

Pull request overview

Extends the Activities tab “Only changes” filter to treat target/observed-in version snapshot changes (work_package_version_journals) as real journal changes, so version-only updates are no longer hidden from the activity feed.

Changes:

• Add version snapshot comparison (work_package_version_journals) to the SQL-based journal change detection.
• Add paginator specs covering version add/remove, snapshot-only no-op, and cross-kind moves (target ↔ observed-in).

File summaries

File	Description
spec/services/work_packages/activities_tab/paginator_spec.rb	Adds regression coverage ensuring version-only journal changes are included by the “Only changes” filter, including cross-kind moves.
app/services/work_packages/activities_tab/paginator/journal_changes_filter.rb	Includes version snapshot side-table comparison in the SQL EXISTS heuristics to detect version-related journal changes.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Warning

Flaky specs

• rspec ./modules/meeting/spec/features/recurring_meetings/recurring_meeting_global_create_spec.rb[1:1:2]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25128, linked for reference only):

- `rspec ./modules/meeting/spec/features/recurring_meetings/recurring_meeting_global_create_spec.rb[1:1:2]`

Treat this as a standalone task, unrelated to PR #25128. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25128 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @akabiru to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @akabiru, and request a review from @akabiru.
On every commit, set @akabiru as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

[github-actions]

Warning

Flaky specs

• rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:2:1]
• rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:3:1]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25128, linked for reference only):

- `rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:2:1]`
- `rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:3:1]`

Treat this as a standalone task, unrelated to PR #25128. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25128 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @akabiru to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @akabiru, and request a review from @akabiru.
On every commit, set @akabiru as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

[github-actions]

Deploying openproject with ⚡ PullPreview

Field	Value
Latest commit	0e9c7be
Job	deploy
Status	✅ Deploy successful
Preview URL	https://pr-25128-comms-997-only-cha-ip-88-99-85-103.my.opf.run:443

View logs

[thykel]

🚀 🚀