Skip to content

Add receiver refinement in getAnnotatedTypeLhs#210

Closed
AndrewShf wants to merge 10 commits into
opprop:masterfrom
AndrewShf:fix_getAnnotatedTypeLhs
Closed

Add receiver refinement in getAnnotatedTypeLhs#210
AndrewShf wants to merge 10 commits into
opprop:masterfrom
AndrewShf:fix_getAnnotatedTypeLhs

Conversation

@AndrewShf

@AndrewShf AndrewShf commented Apr 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

See if the modification can pass all tests

@AndrewShf AndrewShf changed the title just a test pr, see if there's any testcase failure Add receiver refinement in getAnnotatedTypeLhs Apr 11, 2022
@AndrewShf

AndrewShf commented Apr 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

This is an alternative to lnsun's pull request #142
, where he wanted to expose private member computingAnnotatedTypeMirrorOfLHS, so he could override getAnnotatedTypeLhs and had receiver refinement in PICO type system.

AndrewShf
AndrewShf commented Apr 29, 2022
View reviewed changes
Comment thread framework/tests/viewpointtest/TestGetAnnotatedLhs.java
@AndrewShf

AndrewShf commented Mar 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Another way of achieving this: in ExpressionVisitor to have flow-sensitive refinement for receiver?
https://github.com/eisop/checker-framework/blob/c464d12ea98ba1206f3016bee48c74d88881c052/framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java#L273

@AndrewShf AndrewShf mentioned this pull request Mar 10, 2023
Merged
@AndrewShf

AndrewShf commented Jun 28, 2023

Copy link
Copy Markdown
Member Author

this PR is replaced by eisop#434

@AndrewShf AndrewShf closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndrewShf