feat: ManifestPackage evaluation - #28
Merged
Merged
Conversation
Mr-Leshiy
changed the title
ManifestType enum, as_str for Ecosystem, evaluate tests and examples
Mr-Leshiy
changed the title
ManifestType enum, as_str for Ecosystem, evaluate tests and examplesManifestPackage evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing to the project!
Please fill out this template to help us review your changes.
Related Issue(s) (Optional)
N/A
Changes
osv-types: AddedIntoStaticStrderive toEcosystemandas_str(self) -> &'static str— returns a&'static strwithout allocating.osv-analyzer: AddedManifestTypeenum (Cargo,Uv) with strum derives (Display,EnumString,IntoStaticStr) andas_str.Manifest::extractnow takesManifestTypeinstead ofEcosystem.version.rsandmanifest.rstest cases to use typed enum variants instead of raw string literals. Addedevaluate.rsintegration tests that run against real OSV JSON records fromtestdata/osv_records/, with a comment showing how to fetch new records viascripts/fetch_osv_record.sh.manifest_extraction.rsandevaluate.rsexamples.osv-analyzer/Cargo.toml: Addedserde_jsonas a dev-dependency.