-
Notifications
You must be signed in to change notification settings - Fork 6
Fix ANN001 violations #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request adds explicit type annotations across multiple test files in the SDK test suite. The configuration file pyproject.toml was updated to remove type-checking exemptions (ANN001 rules) for unit test files under tests/unit/sdk/. Subsequently, test fixtures in conftest.py and test functions across several test modules received explicit type hints for parameters and return values, using TYPE_CHECKING guards for conditional imports where appropriate. The changes maintain existing test logic and behavior while improving static type information. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
86d4c7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://774b0b4c.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-remaining-ann001.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## stable #753 +/- ##
==========================================
- Coverage 80.39% 80.32% -0.07%
==========================================
Files 115 115
Lines 10127 9888 -239
Branches 1624 1520 -104
==========================================
- Hits 8142 7943 -199
+ Misses 1431 1417 -14
+ Partials 554 528 -26
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
f7d835e to
3e77471
Compare
3e77471 to
86d4c7c
Compare
Fix remaining ANN001 violations and remove exceptions in pyproject.toml.
Summary by CodeRabbit
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.