Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions internal/ai/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ type DefaultAnalyzer struct {
cache *Cache
privacy PrivacyMode
logger *slog.Logger

maxTokens int
temperature float64
}

// AnalyzerConfig holds configuration for constructing a DefaultAnalyzer.
Expand All @@ -28,6 +31,9 @@ type AnalyzerConfig struct {
Cache *Cache
Privacy PrivacyMode
Logger *slog.Logger

MaxTokens int
Temperature float64
}

// NewAnalyzer creates a DefaultAnalyzer.
Expand All @@ -41,10 +47,12 @@ func NewAnalyzer(cfg AnalyzerConfig) *DefaultAnalyzer {
logger = slog.New(slog.NewTextHandler(io.Discard, nil))
}
return &DefaultAnalyzer{
provider: cfg.Provider,
cache: cfg.Cache,
privacy: privacy,
logger: logger,
provider: cfg.Provider,
cache: cfg.Cache,
privacy: privacy,
logger: logger,
maxTokens: cfg.MaxTokens,
temperature: cfg.Temperature,
}
}

Expand Down Expand Up @@ -73,6 +81,8 @@ func (a *DefaultAnalyzer) Analyze(ctx context.Context, req doctor.AnalysisReques
completion, err := a.provider.Complete(ctx, CompletionRequest{
SystemPrompt: SystemPrompt,
UserPrompt: userPrompt,
MaxTokens: a.maxTokens,
Temperature: a.temperature,
})
if err != nil {
return nil, fmt.Errorf("AI provider %s: %w", a.provider.Name(), err)
Expand Down
36 changes: 35 additions & 1 deletion internal/ai/analyzer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,15 @@ type scriptedProvider struct {
model string
err error
calls atomic.Uint64

lastReq CompletionRequest
}

func (p *scriptedProvider) Name() string { return "scripted" }

func (p *scriptedProvider) Complete(_ context.Context, _ CompletionRequest) (*CompletionResponse, error) {
func (p *scriptedProvider) Complete(_ context.Context, req CompletionRequest) (*CompletionResponse, error) {
p.calls.Add(1)
p.lastReq = req
if p.err != nil {
return nil, p.err
}
Expand Down Expand Up @@ -92,6 +95,37 @@ func TestAnalyzerUsesDiscardLoggerWhenNil(t *testing.T) {
}
}

func TestAnalyzerWiresConfiguredMaxTokensAndTemperature(t *testing.T) {
cases := []struct {
name string
maxTokens int
temperature float64
}{
{"configured values ride the request", 2048, 0.7},
{"zero stays zero so provider keeps its default", 0, 0},
}
for _, c := range cases {
t.Run(c.name, func(t *testing.T) {
prov := &scriptedProvider{text: `{"summary":"ok"}`}
a := NewAnalyzer(AnalyzerConfig{
Provider: prov,
Logger: newSilentAILogger(),
MaxTokens: c.maxTokens,
Temperature: c.temperature,
})
if _, err := a.Analyze(context.Background(), doctor.AnalysisRequest{Signals: emptySignals()}); err != nil {
t.Fatalf("Analyze error: %v", err)
}
if prov.lastReq.MaxTokens != c.maxTokens {
t.Errorf("request MaxTokens = %d, want %d", prov.lastReq.MaxTokens, c.maxTokens)
}
if prov.lastReq.Temperature != c.temperature {
t.Errorf("request Temperature = %v, want %v", prov.lastReq.Temperature, c.temperature)
}
})
}
}

func TestAnalyzerMarkdownFencedJSON(t *testing.T) {
prov := &scriptedProvider{text: "Here you go:\n```json\n{\"summary\":\"ok\"}\n```\n"}

Expand Down
10 changes: 6 additions & 4 deletions internal/cli/doctor.go
Original file line number Diff line number Diff line change
Expand Up @@ -453,10 +453,12 @@ func buildAnalyzer(c *config.Config, logger *slog.Logger) (doctor.Analyzer, erro
}

return ai.NewAnalyzer(ai.AnalyzerConfig{
Provider: provider,
Cache: cache,
Privacy: privacy,
Logger: logger,
Provider: provider,
Cache: cache,
Privacy: privacy,
Logger: logger,
MaxTokens: aiCfg.MaxTokens,
Temperature: aiCfg.Temperature,
}), nil
}

Expand Down
Loading