This repository was archived by the owner on Jan 14, 2025. It is now read-only.
(#16) Missing dependency on clojure.tools.nrepl#17
Open
EthanEChristian wants to merge 1 commit intooracle-samples:masterfrom
Open
(#16) Missing dependency on clojure.tools.nrepl#17EthanEChristian wants to merge 1 commit intooracle-samples:masterfrom
EthanEChristian wants to merge 1 commit intooracle-samples:masterfrom
Conversation
mrrodriguez
reviewed
Apr 22, 2019
Collaborator
mrrodriguez
left a comment
mrrodriguez
left a comment
There was a problem hiding this comment.
Added a potential suggestion, so will hold off on the approve.
| [com.cerner/clara-rules "0.19.1"] | ||
|
|
||
| ;; Dependencies for com.cemerick/austin | ||
| [org.clojure/tools.nrepl "0.2.13"] |
Collaborator
There was a problem hiding this comment.
This is a dep of com.cemerick/austin which is a pretty old thing to use for cljs.
If this is accurate, I think that:
- It'd make more sense for it to be in the
:devprofile of:profiles - As is the case in the main clara project, I think the cljs hooks should be removed so that the clj-side repl setup doesn't require cljs building/running at all. Some people don't care about that.
(2) Is probably something that can be looked at later once the main clara-rules project is doing a similar pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.