Skip to content

ODSC-85044: Improve AQUA shape recommender fallback for nested text_config model configs#1362

Open
Aryanag2 wants to merge 1 commit intomainfrom
odsc-85044-text-config-fallback
Open

ODSC-85044: Improve AQUA shape recommender fallback for nested text_config model configs#1362
Aryanag2 wants to merge 1 commit intomainfrom
odsc-85044-text-config-fallback

Conversation

@Aryanag2
Copy link
Copy Markdown
Contributor

Jira

  • Ticket: ODSC-85044

What Changed

  • Added a nested decoder fallback in LLMConfig.from_raw_config() so recommender parsing can use text_config or similar nested text sections when top-level decoder fields are missing.
  • Kept top-level config values authoritative while validating nested decoder sections so unsupported nested decoders still return descriptive AquaRecommendationError messages.
  • Updated focused AQUA recommender unit coverage for supported nested text_config parsing and unsupported nested decoder validation.

Validation

  • python3 -m pytest tests/unitary/with_extras/aqua/test_recommend.py -k text_config
  • python3 -m pytest tests/unitary/with_extras/aqua/test_recommend.py -k valid

Risks / Follow-Ups

  • The fallback only fills missing decoder fields; broader nested config handling remains unchanged.

Checklist

  • PR title follows <JIRA-KEY>: <summary>
  • Changes are scoped to the ticket
  • Relevant tests were added or updated
  • Validation steps are documented above
  • Commits are signed off

Signed-off-by: Aryan Gosaliya <aryan.gosaliya@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants