Skip to content

Fix memory allocation error handling by closing file #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yss-ef wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix memory allocation error handling by closing file #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
499c45a
Fix memory allocation error handling by closing file
yss-ef Apr 23, 2026
b8d4efd
Fix Resource leak
yss-ef Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fdrd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ saveto(struct instance *insp, struct item *itp)
int
read_config_file(const char *fpath, const struct stat *sb, int typeflag)
{
FILE *f;
FILE *f;
char buf[BUFSIZE], save_buf[BUFSIZE], *bp;
int l;
struct item *itp;
Expand Down Expand Up @@ -590,6 +590,7 @@ read_config_file(const char *fpath, const struct stat *sb, int typeflag)
insp = malloc(sizeof(struct instance));
if (insp == NULL) {
perror("malloc");
fclose(f)
return 1;
}
insque(insp, &anchor);
Expand Down Expand Up @@ -637,6 +638,7 @@ read_config_file(const char *fpath, const struct stat *sb, int typeflag)
itp = malloc(sizeof(struct item));
if (itp == NULL) {
perror("malloc");
fclose(f);
exit(EC_MALLOC);
}

Expand Down Expand Up @@ -714,6 +716,7 @@ read_config_file(const char *fpath, const struct stat *sb, int typeflag)
insp->ilast = itp;
}
}
fclose(f);
return 0;
}

Expand Down