Skip to content

feat(sinks): enable sinks with noauth.#2857

Draft
lpegoraro wants to merge 10 commits into
orb-community:developfrom
lpegoraro:eng-1753-noauth-sink-poc
Draft

feat(sinks): enable sinks with noauth.#2857
lpegoraro wants to merge 10 commits into
orb-community:developfrom
lpegoraro:eng-1753-noauth-sink-poc

Conversation

@lpegoraro

@lpegoraro lpegoraro commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

TODOs

  • Integration test on local machine

Enable sinks to be configured withou username/password.

When creating sinks with NoAuth using the following sample configuration.

authentication:
  type: noauth
exporter:
  remote_host: https://localhost:6657

would generate the following otel collector.

---
receivers:
  kafka:
    brokers:
    - kafka:9092
    topic: otlp_metrics-sink-id-22
    protocol_version: 2.0.0
extensions:
  pprof:
    endpoint: 0.0.0.0:1888
exporters:
  otlphttp:
    endpoint: https://localhost:6657
service:
  extensions:
  - pprof
  pipelines:
    metrics:
      receivers:
      - kafka
      exporters:
      - otlphttp

Results
Sink is created successfully
image

Maestro is able to spin collector succesfully without the basicauth extension.
image

@lpegoraro lpegoraro self-assigned this Dec 8, 2023
@github-actions github-actions Bot added the golang label Dec 8, 2023
@codecov-commenter

codecov-commenter commented Dec 8, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.99%. Comparing base (583c5fd) to head (6f968ae).
⚠️ Report is 208 commits behind head on develop.

Files with missing lines Patch % Lines
maestro/deployment/service.go 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2857      +/-   ##
===========================================
+ Coverage    48.53%   57.99%   +9.46%     
===========================================
  Files           85       67      -18     
  Lines         6330     5216    -1114     
===========================================
- Hits          3072     3025      -47     
+ Misses        3258     2191    -1067     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpegoraro lpegoraro marked this pull request as ready for review December 11, 2023 14:50
@lpegoraro lpegoraro marked this pull request as draft December 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants