Skip to content

chore: remove orbinum-signature-api from dependencies and related code #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nol4lej merged 1 commit into from
Mar 7, 2026
Merged

chore: remove orbinum-signature-api from dependencies and related code #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ members = [
"frame/account-mapping/runtime-api",
"frame/account-mapping/rpc",
"frame/evm/precompile/account-mapping",
"frame/signature-api",
"client/api",
"client/consensus",
"client/rpc-core",
Expand Down Expand Up @@ -227,7 +226,6 @@ orbinum-zk-core = { path = "primitives/zk-core", default-features = false }
orbinum-zk-verifier = { path = "primitives/zk-verifier", default-features = false }

# Frontier FRAME
orbinum-signature-api = { path = "frame/signature-api", default-features = false }
pallet-account-mapping = { path = "frame/account-mapping", default-features = false }
pallet-account-mapping-rpc = { path = "frame/account-mapping/rpc" }
pallet-account-mapping-runtime-api = { path = "frame/account-mapping/runtime-api", default-features = false }
Expand Down
28 changes: 0 additions & 28 deletions frame/signature-api/Cargo.toml
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions frame/signature-api/src/lib.rs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions template/runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ pallet-evm-precompile-sha3fips-benchmarking = { workspace = true }
pallet-evm-precompile-simple = { workspace = true }

# Orbinum Privacy
orbinum-signature-api = { workspace = true }
orbinum-zk-verifier = { workspace = true, default-features = false }
pallet-shielded-pool = { workspace = true }
pallet-shielded-pool-runtime-api = { workspace = true }
Expand Down Expand Up @@ -149,7 +148,6 @@ std = [
"pallet-evm-precompile-curve25519-benchmarking/std",
"pallet-evm-precompile-account-mapping/std",
# Orbinum Privacy
"orbinum-signature-api/std",
"pallet-zk-verifier/std",
"pallet-shielded-pool/std",
"pallet-shielded-pool/poseidon-native",
Expand Down
21 changes: 0 additions & 21 deletions template/runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,27 +1257,6 @@ impl_runtime_apis! {
}
}

// SignatureApi RuntimeAPI implementation
impl orbinum_signature_api::SignatureApi<Block> for Runtime {
fn get_supported_signature_types() -> alloc::vec::Vec<orbinum_signature_api::SignatureType> {
// Sr25519 primero: tipo preferido para cuentas Substrate-nativas.
// Ecdsa segundo: para cuentas derivadas de claves Ethereum.
alloc::vec![
orbinum_signature_api::SignatureType::Sr25519,
orbinum_signature_api::SignatureType::Ecdsa,
]
}

fn validate_signature(
signature: sp_runtime::MultiSignature,
message: alloc::vec::Vec<u8>,
signer: sp_core::crypto::AccountId32,
) -> bool {
use sp_runtime::traits::Verify;
signature.verify(message.as_slice(), &signer)
}
}

#[cfg(feature = "runtime-benchmarks")]
impl frame_benchmarking::Benchmark<Block> for Runtime {
fn benchmark_metadata(extra: bool) -> (
Expand Down
93 changes: 1 addition & 92 deletions template/runtime/src/runtime_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,16 +274,10 @@ fn multisignature_variants_have_correct_byte_sizes() {
}

fn api_validate_signature(signature: MultiSignature, message: &[u8], signer: &AccountId) -> bool {
use sp_runtime::traits::Verify;
signature.verify(message, signer)
}

fn api_get_supported_types() -> alloc::vec::Vec<orbinum_signature_api::SignatureType> {
alloc::vec![
orbinum_signature_api::SignatureType::Sr25519,
orbinum_signature_api::SignatureType::Ecdsa,
]
}

fn sr25519_account(derivation: &str) -> (sr25519::Pair, AccountId) {
let pair = sr25519::Pair::from_string(derivation, None).unwrap();
let account: AccountId = MultiSigner::from(pair.public()).into_account();
Expand All @@ -296,91 +290,6 @@ fn ecdsa_account(derivation: &str) -> (ecdsa::Pair, AccountId) {
(pair, account)
}

#[test]
fn signature_api_returns_sr25519_and_ecdsa() {
use orbinum_signature_api::SignatureType;
let types = api_get_supported_types();
assert!(types.contains(&SignatureType::Sr25519));
assert!(types.contains(&SignatureType::Ecdsa));
assert_eq!(types.len(), 2, "Only Sr25519 and Ecdsa must be registered");
}

#[test]
fn signature_api_sr25519_is_first_preferred_type() {
use orbinum_signature_api::SignatureType;
let types = api_get_supported_types();
assert_eq!(
types[0],
SignatureType::Sr25519,
"Sr25519 must be the first type (preferred)"
);
}

#[test]
fn signature_type_scale_discriminants_are_stable() {
use orbinum_signature_api::SignatureType;
use scale_codec::Encode;
assert_eq!(SignatureType::Sr25519.encode(), vec![0u8]);
assert_eq!(SignatureType::Ed25519.encode(), vec![1u8]);
assert_eq!(SignatureType::Ecdsa.encode(), vec![2u8]);
}

#[test]
fn signature_api_validate_sr25519_valid_signature() {
let (pair, account) = sr25519_account("//Alice");
let msg = b"orbinum-signature-api-test";
let multi_sig = MultiSignature::Sr25519(pair.sign(msg));
assert!(api_validate_signature(multi_sig, msg, &account));
}

#[test]
fn signature_api_validate_ecdsa_valid_signature() {
let (pair, account) = ecdsa_account("//Alice");
let msg = b"orbinum-signature-api-test";
let multi_sig = MultiSignature::Ecdsa(pair.sign(msg));
assert!(api_validate_signature(multi_sig, msg, &account));
}

#[test]
fn signature_api_validate_wrong_signer_rejected() {
let (alice, _) = sr25519_account("//Alice");
let (_, bob_account) = sr25519_account("//Bob");
let msg = b"test-message";
let multi_sig = MultiSignature::Sr25519(alice.sign(msg));
assert!(!api_validate_signature(multi_sig, msg, &bob_account));
}

#[test]
fn signature_api_validate_wrong_message_rejected() {
let (pair, account) = sr25519_account("//Alice");
let signed_msg = b"original-message";
let wrong_msg = b"modified-message";
let multi_sig = MultiSignature::Sr25519(pair.sign(signed_msg));
assert!(!api_validate_signature(multi_sig, wrong_msg, &account));
}

#[test]
fn signature_api_validate_corrupted_signature_rejected() {
let (pair, account) = sr25519_account("//Alice");
let msg = b"test-message";
let mut raw_sig = pair.sign(msg);
raw_sig.0[0] ^= 0xFF;
raw_sig.0[1] ^= 0xFF;
let multi_sig = MultiSignature::Sr25519(raw_sig);
assert!(!api_validate_signature(multi_sig, msg, &account));
}

#[test]
fn signature_api_validate_wrong_signature_type_rejected() {
let (sr_pair, sr_account) = sr25519_account("//Alice");
let msg = b"cross-type-test";
let sr_raw = sr_pair.sign(msg);
let mut ecdsa_bytes = [0u8; 65];
ecdsa_bytes[..64].copy_from_slice(&sr_raw.0[..64]);
let multi_sig = MultiSignature::Ecdsa(ecdsa::Signature::from_raw(ecdsa_bytes));
assert!(!api_validate_signature(multi_sig, msg, &sr_account));
}

#[test]
fn check_nonce_signed_extension_is_constructable() {
let _: frame_system::CheckNonce<Runtime>;
Expand Down
Loading