Add oracle support#64
Merged
Merged
Conversation
Adds an `oracle { }` DSL provider alongside `postgres` and `mysql`, backed by
the Testcontainers oracle-xe module and the Oracle JDBC driver.
- SqlDsl: new `oracle()` builder using OracleContainer + SQLDialect.ORACLE
- pom: add testcontainers oracle-xe + ojdbc11; switch jOOQ to the commercial
org.jooq.pro artifact (the OSS edition omits the Oracle dialect)
- DatabaseExecutor: load fixture rows one INSERT at a time. Oracle rejects
multi-row VALUES and jOOQ's emulation isn't portable; single-row inserts are
valid on every supported database (Postgres/MySQL unaffected)
- Tests + docs covering Oracle's uppercase identifiers and native types
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The build depends on org.jooq.pro:jooq, served from the authenticated
repo.jooq.org. CI ran `mvn clean deploy` with no credentials for that
repo, so a clean runner would 401 resolving the dependency.
Mirror the pattern used in vyne: a checked-in .mvn/settings.xml that
maps the jooq-pro server to ${env.JOOQ_REPO_USERNAME}/${env.JOOQ_REPO_PASSWORD},
invoked via `--settings .mvn/settings.xml`, with the values supplied from
GitHub secrets. Maven does not auto-read .mvn/settings.xml, so local
builds are unaffected and continue using ~/.m2/settings.xml.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for orbital-nebula ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.