Add alternate device_characteristics/sector_size methods which pass file handle#72
Merged
carlsverre merged 1 commit intoorbitinghail:mainfrom Feb 24, 2026
Merged
Conversation
bkoropoff
force-pushed
the
device-handle
branch
from
7b6c132 to
9e660d6
Compare
Contributor
|
Honestly I'd rather just break backwards incompatibility. I should have always made those fns pass through the handle. Mind updating? |
The location of the opened file may influence the results.
bkoropoff
force-pushed
the
device-handle
branch
from
9e660d6 to
c00dd7d
Compare
Contributor
Author
|
Done |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some VFS backends the location of the opened file may influence the results. I added new methods keyed off defaulted associated constants to avoid breaking library compatibility. The new methods have default impls that will panic, but you have to opt in to them being called.