Closed
Conversation
This requires a new associated type for mapped pages/regions. It can set to something trivial like [u8; 0] if unused. The lifetime semantics of returned mapped regions are odd: the regions are cached until all being released at once with `xShmUnmap`. In order to present a safe interface to Rust, the region handles are kept in boxes (for address stability) in a `Vec` and then dropped all at once. I'm still considering whether a more efficient design is possible without restoring to `unsafe` trait methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires a new associated type for mapped pages/regions. It can
set to something trivial like
[u8; 0]if unused.The lifetime semantics of returned mapped regions are odd: the regions
are cached until all being released at once with
xShmUnmap. In orderto present a safe interface to Rust, the region handles are kept in
boxes (for address stability) in a
Vecand then dropped all at once.I'm still considering whether a more efficient design is possible
without resorting to
unsafetrait methods.