[AMM-163] apply recent rust-sdk tx-sender updates to ts library#2
Open
jshiohaha wants to merge 3 commits intoshio/migrate-from-whirlpoolsfrom
Open
[AMM-163] apply recent rust-sdk tx-sender updates to ts library#2jshiohaha wants to merge 3 commits intoshio/migrate-from-whirlpoolsfrom
jshiohaha wants to merge 3 commits intoshio/migrate-from-whirlpoolsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
📔 if approved, i will aim to merge #1 first, and this PR's base branch will switch to
main. the current setup is to keep a nice diff while the other PRs changes are reviewed.Retroactively apply some tx-sender features from rust -> ts. Note that
@solana/kithandles a lot of this out of the box. The main reason for these changes is that it aligns the Rust and TS interfaces.@solana/kitlibrary'spartiallySignTransactionMessageWithSignersfunctionTesting
Run the full setup and test commands:
yarn clean && yarn && yarn build && yarn format && yarn lint && yarn testUnit tests
Update the ts unit tests to verify that the compute unit estimators are or are not called