Move HydrophoneLocations into shared DTO, initialize it from Orcasite feeds, and drive email map URI tests from it#510
Open
Copilot wants to merge 7 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/orcasound/orcahello/sessions/deb5444e-0e40-425f-8d6d-16bab8bb908d Co-authored-by: dthaler <6547784+dthaler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move hydrophone locations to utilities project
Move HydrophoneLocations into shared DTO and drive email map URI tests from it
May 26, 2026
dthaler
reviewed
May 26, 2026
Agent-Logs-Url: https://github.com/orcasound/orcahello/sessions/5b32b81f-7187-4857-8285-761f90da51e0 Co-authored-by: dthaler <6547784+dthaler@users.noreply.github.com>
dthaler
approved these changes
May 26, 2026
dthaler
reviewed
May 26, 2026
Agent-Logs-Url: https://github.com/orcasound/orcahello/sessions/7ee423ac-9401-434a-8039-616a63f88c90 Co-authored-by: dthaler <6547784+dthaler@users.noreply.github.com>
dthaler
approved these changes
May 26, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Copilot
AI
changed the title
Move HydrophoneLocations into shared DTO and drive email map URI tests from it
Move HydrophoneLocations into shared DTO, initialize it from Orcasite feeds, and drive email map URI tests from it
May 26, 2026
This comment was marked as resolved.
This comment was marked as resolved.
dthaler
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hydrophone location mappings were defined only in
AIForOrcas.Client.Web, whileNotificationSystem.Tests.Unitduplicated location-name expectations inline. This change centralizes the mapping in a reusable project, initializes that shared map from Orcasite feed data when available, makes the email map URI tests consume the same initialization path, and trims unused DTO API surface that was introduced during the move.Shared hydrophone location mapping
HydrophoneLocationsfromAIForOrcas.Client.WebtoAIForOrcas.DTOInitialize,GetIdByLocation,Locations)LocationToIdMapandHydrophoneIdsproperties after verifying they had no callers in the repositoryOrcasite-backed initialization
AIForOrcas.DTOreference toNotificationSystemOrcasiteHelper.InitializeAsync()to use the feeds array from Orcasite to build the shared{ location name -> node_name }map and callHydrophoneLocations.Initialize(...)NotificationSystem test alignment
NotificationSystem.Tests.UnittoAIForOrcas.DTOInlineDatainEmailTemplateTestswithMemberDatabacked byHydrophoneLocations.LocationsHydrophoneLocations.GetIdByLocation(locationName)OrcasiteHelperwith mocked Orcasite feed data viaInitializeAsync()instead of hand-mocking slug lookupsEffect on duplicated test data
Mast Center/MaST Center,Haro Strait)