Repository navigation
feat(mar-882): Ask the chief opens a prefilled composer (redo, no boundary above the heading) - #353
Merged
Merged
Conversation
…ndary above the heading) Reapplies the prefill mechanism from #349 (reverted as #351 after shell-smoke found the fleet page's first paint had 0 headings). The regression was a Suspense boundary wrapped around app/page.tsx's default export so an inner component could call useSearchParams; this redo never touches app/page.tsx at all. ChiefChat already receives the fleet as its own `agents` prop, so it resolves `?ask=<agent>` from window.location.search inside a mount effect instead, with a new tests/fleet-first-paint.test.tsx guarding against a future Suspense/ useSearchParams reintroduction. Local shell-smoke on a scratch store confirms proof 1 now reads headings:1 (85 PASS / 0 FAIL overall). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Thebeatkicks
marked this pull request as ready for review
September 7, 2026 11:23
…hief-prefill-redo
Thebeatkicks
added a commit
that referenced
this pull request
Sep 7, 2026
chore(state): MAR-882 merged via #353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"About <agent title>: "and focus, without wrappingapp/page.tsx's default export inSuspense.Suspenseboundary above the fleet page's own<h1>: this app's static export serves the fallback (no heading) as its first paint untiluseSearchParamsresolves, which is exactly what master's post-merge shell-smoke caught (headings: 0atdash-app://ui/).app/page.tsx.ChiefChatalready receives the whole fleet as itsagentsprop, so it resolves its own?ask=<agent>fromwindow.location.searchinside a mount effect instead of taking a prop computed by auseSearchParamscall above the heading.app/_data/routes.ts(chiefAskHref/CHIEF_ASK_PARAM),lib/copy/chief-chat.ts(describeChiefPrefill),app/_components/composer.tsx(focusSignal), andapp/_components/ask.tsx(the two chief-entry links) are reapplied unchanged from feat(mar-882): Ask the chief opens a prefilled composer #349 — none of them depended on how the id reachesChiefChat.tests/fleet-first-paint.test.tsxsource-grepsapp/page.tsxforSuspense/useSearchParamsand rendersAgentsPageviarenderToStaticMarkup, asserting the<h1>is present — the regression guard for this exact defect.Test plan
pnpm typecheck— cleanpnpm brand:check— passedpnpm test(whole suite, 281 files / 5337 tests / 13 skipped) — all passed, no flakespnpm build:renderer+pnpm build:shell— both succeeded--user-data-dir/DASH_DATA_DIRboth scoped, basenameorchestratedash): proof 1 now reads{"headings":1}atdash-app://ui/(was0on master post-feat(mar-882): Ask the chief opens a prefilled composer #349); final tally 85 PASS / 0 FAIL,[smoke] all proofs passed. Scratch runner retired afterward viascripts/retire-scratch-runners.mjs(RETIRED).docs/mar-882-handoff.md's "Evidence class" and "What is NOT done".See
docs/mar-882-handoff.mdfor the full account, including the one open question about a re-render edge case (appliedPrefillremembering a dismissed prefill across an unrelatedagentsreference change) named under "What is NOT done" item 3.🤖 Generated with Claude Code