Skip to content

chore: add pull request template #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdeGneus merged 1 commit into from
May 15, 2026
Merged

chore: add pull request template #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
## What does this PR do?

<!-- Describe the change. Focus on WHY, not just what. -->

## Type of change

- [ ] `feat` - new CLI command, output mode, bridge integration, or operator workflow
- [ ] `fix` - bug fix or command behavior correction
- [ ] `docs` - documentation only
- [ ] `test` - tests only
- [ ] `refactor` - no behavior change
- [ ] `security` - touches tokens, deploy keys, credentials, or local runtime authority
- [ ] `contract-change` - changes bridge, output JSON, cloud, Hub, or SDK contract usage

## Required checklist

- [ ] Linked issue is included below and acceptance criteria are addressed
- [ ] `go test ./...` passes
- [ ] `go vet ./...` passes
- [ ] Pre-commit passes for changed files
- [ ] Every new `.go` file has the Apache-2.0 license header
- [ ] Command help text is updated for new or changed flags
- [ ] JSON output is deterministic and tested when `--output json` is supported

## CLI authority and safety checklist

- [ ] Runtime-owned behavior delegates through the runtime bridge; the CLI does not parse `ori.yaml` independently
- [ ] State queries go through the bridge; the CLI does not open runtime SQLite directly
- [ ] Deploy keypairs are generated on-device; private keys never leave the device
- [ ] Token commands never print raw token material except the explicit one-time generate result
- [ ] Text output is operator-readable and error output is clear on stderr

## External integration checklist

Complete if this PR touches runtime bridge, cloud, Hub, or SDK integrations.

- [ ] Timeout, malformed JSON, auth failure, and unavailable service paths are tested
- [ ] Secrets and private keys never appear in logs or errors
- [ ] Noninteractive behavior is documented and tested if added

## If you used AI assistance

- [ ] I can explain every line of AI-generated code in this PR
- [ ] I have read and understood every file I modified
- [ ] I am not submitting code I cannot defend in review

## Related issue

<!-- Closes #<issue-number> -->

## Testing notes

<!-- Include commands run and any intentionally skipped checks. -->
Loading