updated SUPPORTED_PROTOCOL constant to 37#29
Open
rrmerugu wants to merge 1 commit intoorientechnologies:masterfrom
Open
updated SUPPORTED_PROTOCOL constant to 37#29rrmerugu wants to merge 1 commit intoorientechnologies:masterfrom
rrmerugu wants to merge 1 commit intoorientechnologies:masterfrom
Conversation
this shall possibly support orientdb 3.0.0
Author
|
may be this shall call for version increment also !! in constants.py ! |
Author
|
@Ostico are there any modifications needed for this codebase to support orientdb 3.0.0 !! |
|
Hi @rrmerugu, Unfortunately, this solution won't work with OrientDB 3.0.3 and later. It now adds a check to protocol 37 during the connect phase to see if a handshake were used. It fails otherwise. The simplest solution is to still use protocol 36 (OrientDB will adjust accordingly) until the handshake, etc. can be implemented and to comment out this in orient.py: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this shall possibly support orientdb 3.0.0