Skip to content

feat: add Foundry hosted Responses adapter - #270

Closed
Sertaç Özercan (sozercan) wants to merge 51 commits into
mainfrom
foundry-hosted
Closed

Sertaç Özercan (sozercan) wants to merge 51 commits into
mainfrom
foundry-hosted

Conversation

@sozercan

Copy link
Copy Markdown
Member

Summary

  • Add examples/harness/foundry-responses, a new orka.harness.v1 adapter for Foundry hosted AgentKit endpoint-scoped /responses.
  • Map hosted Responses function_call outputs to Orka ToolCallRequested, and map Orka ToolCallResult continuations back to hosted function_call_output with canonical success/error envelopes.
  • Keep Orka authoritative: the adapter does not send request-level tools, validates requested function names/classes against StartTurnRequest.input.tools, and never forwards Tool URLs/credential refs.
  • Add fake-server tests, golden fixtures, imported AgentKit brokered fixtures, conformance coverage, write approval-decline/failure paths, restart/session/fail-closed behavior, and status/redirect/large-output hardening.
  • Add Foundry Responses docs, Kubernetes smoke skeleton, live smoke/evidence helpers, Fibey read/write manifests, and validation matrix.

Validation

  • examples/harness/foundry-responses/validate.sh --full --agentkit /Users/sozercan/projects/agentkit
    • Includes focused Orka adapter/harness/controller suites.
    • Includes make test full non-e2e suite.
    • Includes AgentKit deterministic Foundry brokered protocol/schema tests.
  • .agents/skills/autoreview/scripts/autoreview --mode commit --commit HEAD

Notes / remaining live gates

Local deterministic coverage is complete for the adapter/fixture path, but these gates still require live Foundry/AgentKit/Fibey infrastructure:

  • real Foundry hosted AgentKit smoke,
  • deployed hosted /responses function-call/function-call-output continuation,
  • Fibey Foundry-hosted brokered read/write approval E2E with collected evidence.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 60/62 changed files
  • Comments generated: 3
  • Review effort level: Medium

Comment thread examples/harness/foundry-responses/main.go Outdated
Comment thread examples/fibey-custom-agent-demo/verify-foundry-responses.sh Outdated
Comment thread examples/harness/foundry-responses/README.md Outdated
Copilot AI review requested due to automatic review settings July 14, 2026 02:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 60/62 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread examples/fibey-custom-agent-demo/verify-foundry-responses.sh
Comment thread examples/harness/foundry-responses/live-evidence.sh
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 03:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 61/63 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread examples/harness/foundry-responses/live-evidence.sh Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1fe290b1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread examples/harness/foundry-responses/main.go Outdated
Comment thread examples/harness/foundry-responses/main.go
Comment thread examples/harness/foundry-responses/live-evidence.sh Outdated
Comment thread examples/harness/foundry-responses/main.go Outdated
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 03:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/65 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread examples/harness/foundry-responses/main.go
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 03:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/65 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread examples/harness/foundry-responses/live-evidence.sh Outdated
Comment thread go.mod
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 04:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/65 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1227c3a34d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread examples/harness/foundry-responses/main.go
Comment thread examples/harness/foundry-responses/main.go
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings July 14, 2026 05:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 63/65 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@sozercan

Copy link
Copy Markdown
Member Author

Closing as superseded by agent-runtime-foundry. Provider adapters moved out of Orka in #283, and the ongoing Foundry integration belongs in the external adapter's current harness v2 path.

The replacement work is tracked in:

  • agent-runtime-foundry #3: AgentKit continuation proof and tool-result envelope mapping through the current broker.
  • AgentKit #25: companion changes for skills, governed multi-step tool workflows, acknowledgement, and cancellation.

Both replacement PRs remain open. This closure retires the old in-tree harness v1 implementation while that work continues externally.

Human approval-required tool writes remain an unmet part of this PR's original scope. The external v2 replacements explicitly leave them unsupported; they still need separate controller-owned permission work and validation before the original approval-gated write workflow can be considered complete.

The code, fixtures, and review history here remain available as reference for that follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants