Skip to content

feat(examples): restore Fibey demo for harness v2 - #518

Merged
Sertaç Özercan (sozercan) merged 16 commits into
mainfrom
feat/fibey-v2-demo
Sep 14, 2026
Merged

Sertaç Özercan (sozercan) merged 16 commits into
mainfrom
feat/fibey-v2-demo

Conversation

@sozercan

@sozercan Sertaç Özercan (sozercan) commented Sep 8, 2026 •

Copy link
Copy Markdown
Member

Restores the Fibey example for harness v2. Users send the same fictional pump alert to AgentKit in Kubernetes and to AgentKit hosted in Azure AI Foundry, then compare the saved answers with orka task result.

The walkthrough explains Orka terms as they appear and keeps deployment and credentials in the setup guide. Each submission verifies its selected runtime. If a read fails after submission, the script directs users to inspect the existing Task before submitting again. Controller recovery reuses the saved terminal record so a lost status update cannot cause a conflicting rewrite.

The supervisor also fixes a tool-capacity failure found during live validation. When two tool calls are running, an additional call now receives a request-specific capacity error without consuming approval or reaching the tool broker. Tool listing and ping remain available. In the controlled three-call comparison, callbacks failed in 10–22 ms instead of waiting 120 seconds. The two admitted tool effects still completed; the error does not roll them back.

The live runtime tests record bounded failure metadata and recognized error markers from authenticated event responses before checking for successful tool execution. Diagnostics omit tool arguments, output, and arbitrary error text. The Codex read check asks for the file contents without supplying the expected answer in its prompt.

Validation:

  • make lint-fix, make test, focused MCP proxy tests, six submission regressions, and code review passed.
  • All 29 CI checks passed on 1a1da5d0. Both Copilot proxy runs passed 12 selected cases without a retry, and both general E2E runs passed 81 selected cases, including the metrics check.
  • All nine core images were rebuilt for Linux amd64 and Orka was deployed in harness v2 mode on AKS. The four primary demo runtimes then received the capacity fix with verified images that changed only the supervisor executable. Existing hosted agent versions and previous ledgers were preserved.
  • After replacement, both pump demos, a hosted search, and a direct work-order lookup passed. The latter recorded skill loading, discovery, and reading the requested record. Fixture counts matched the governed calls, CLI and API answers matched, and all runtimes returned to idle with cleanup proof.
  • Seven hosted fault Tasks covered HTTP 429 recovery and exhaustion, cancellation during backoff, malformed JSON, empty model results, and invalid tool arguments. The model upstream was a deterministic fixture behind the real Foundry and Orka path. All expected failure assertions passed, with no repeated tool effects. Late cancellation checks found no delayed retries.
  • Both backends handled four active prompts and 31 successful turns in 11 conversations. Cancellation left peers unaffected. Ten resident conversations were accepted, the eleventh was rejected, and admission resumed after deletion. Concurrent governed tool calls matched independent fixture counts. Hosted cleanup matched 44 Tasks to 24 retired remote sessions.
  • Eight handoff/crash cases and two supervisor-alive lost-result cases each executed one tool effect. Exact successful retries returned the same receipt. Six interrupted Tasks retained OutcomeUnknown; both supervisor-alive cases retained an unknown tool-effect record. Evidence and the two earlier uncertain executions remain preserved.

Known limits from the new tests:

  • Answer grounding is unresolved. Across 36 frozen samples, 13 passed, 22 failed, and one returned no assessable answer. Missing and contradictory records were handled in the final samples, but undocumented instrument attributes and misleading retrieved text still produced failures. Three instruction revisions did not establish a fix and are excluded from this change. These sample counts are not reliability estimates, and the two backends used different models.
  • A separate direct smoke claimed it had searched despite having no recorded tool call. Its prompt conflicted with the configured skill workflow. A follow-up using that workflow passed, but did not establish the cause of the first failure; both outcomes are retained.
  • The public Task history does not clearly expose an uncertain external tool effect when the runtime itself fails and cleans up. The durable effect record remains OutcomeUnknown, while public events report a generic tool/Task failure.
  • The controller has four dispatch workers. Runtime rejection of a fifth active prompt, eight simultaneously active prompts across both backends, and the global 16-request HTTP guard were not independently exercised. The sustained test included an expired client-token collection pause, so it is not an uninterrupted load benchmark.

The companion changes are in AgentKit #25 and agent-runtime-foundry #3. No additional source changes were needed in either repository during this validation round.

The demo uses simulated, read-only operational data. Orka governs the outer tool-search and call-tool calls; the fixture constrains their nested operations. No uncertain invocation was replayed or force-cleared.

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI balanced review requested due to automatic review settings September 8, 2026 20:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T19:15:41.086472Z eee9b62 New commits
🔒 Security Review ✅ Completed 2026-09-08T20:29:17.632563Z 74dc1f1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Task sets unsupported agentRuntime.allowBash, preventing runtimeRef reconciliation and binding.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 2 Medium severity

New issues introduced by this change (2)
Severity Finding
Medium severity examples/​fibey-custom-agent-demo/​task.yaml — runtimeRef Tasks reject any task-level agentRuntime.allowBash value, including false…
Medium severity scripts/​tests/​fibey-v2-demo-test.sh — This handwritten fixture includes the same unsupported task-level allowBash field as the…
What changed in this PR

Restores the Fibey harness-v2 demo for direct AgentKit and Foundry-hosted execution.

Changes:

  • Adds both external runtime registrations and shared agent inputs.
  • Adds safe Task submission and immutable-binding verification.
  • Adds documentation, regression tests, and CI triggering.
File Description
.github/​workflows/​coexistence-smoke.yml Triggers smoke tests for demo changes.
examples/​README.md Lists the restored demo.
examples/​fibey-custom-agent-demo/​README.md Documents setup, execution, and limitations.
examples/​fibey-custom-agent-demo/​build-images.md Documents image build and deployment configuration.
examples/​fibey-custom-agent-demo/​Dockerfile.foundry Builds the Foundry-hosted AgentKit wrapper.
examples/​fibey-custom-agent-demo/​foundry-acp.json Configures the Foundry ACP target.
examples/​fibey-custom-agent-demo/​agentkitfile.yaml.example Defines the shared Fibey agent input.
examples/​fibey-custom-agent-demo/​agentruntime-agentkit.yaml Templates direct AgentKit registration.
examples/​fibey-custom-agent-demo/​agentruntime-foundry.yaml Templates Foundry registration.
examples/​fibey-custom-agent-demo/​agent-agentkit.yaml References the AgentKit runtime.
examples/​fibey-custom-agent-demo/​agent-foundry.yaml References the Foundry runtime.
examples/​fibey-custom-agent-demo/​task.yaml Defines the baseline incident Task.
examples/​fibey-custom-agent-demo/​kustomization.yaml Applies only the reference Agents.
examples/​fibey-custom-agent-demo/​switch-backend.sh Creates and verifies one backend-specific Task.
scripts/​tests/​fibey-v2-demo-test.sh Tests submission and binding failure scenarios.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread examples/fibey-custom-agent-demo/task.yaml Outdated
Comment thread scripts/tests/fibey-v2-demo-test.sh Outdated
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 8, 2026 20:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The cross-repository runtime integrations and image contracts were not validated through a live end-to-end execution.

Review tier: Balanced
Findings: None

Issues resolved since last review (2)
Severity Finding
Medium severity scripts/​tests/​fibey-v2-demo-test.sh — This handwritten fixture includes the same unsupported task-level allowBash field as the… View resolved comment
Medium severity examples/​fibey-custom-agent-demo/​task.yaml — runtimeRef Tasks reject any task-level agentRuntime.allowBash value, including false… View resolved comment

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 8, 2026 21:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The exporter can emit endpoint and authentication configurations that the controller subsequently rejects.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 2 Medium severity

New issues introduced by this change (2)
Severity Finding
Medium severity workers/​acp/​supervisor/​registration.go — This check is weaker than the controller’s endpoint validation. For example,…
Medium severity workers/​acp/​supervisor/​registration.go — The exporter accepts identical controller-bearer and operation-capability Secret references, but…

Comment thread workers/acp/supervisor/registration.go Outdated
Comment thread workers/acp/supervisor/registration.go Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c7b47213b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread workers/acp/supervisor/registration.go Outdated
Comment thread examples/fibey-custom-agent-demo/build-images.md Outdated
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 8, 2026 22:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The experimental cross-repository runtime paths were not validated against a live model, warranting final human review.

Review tier: Balanced
Findings: None

Issues resolved since last review (2)
Severity Finding
Medium severity workers/​acp/​supervisor/​registration.go — The exporter accepts identical controller-bearer and operation-capability Secret references, but… View resolved comment
Medium severity workers/​acp/​supervisor/​registration.go — This check is weaker than the controller’s endpoint validation. For example,… View resolved comment

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 8, 2026 23:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The restored example follows external harness-v2 contracts and includes focused validation for manifests, compatibility, bindings, and failure handling.

Review tier: Balanced
Findings: None

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 9, 2026 00:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The documented result queries use a nonexistent Task status field, preventing users from displaying and comparing answers.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 2 Medium severity

New issues introduced by this change (2)
Severity Finding
Medium severity examples/​fibey-custom-agent-demo/​README.md — TaskStatus has no top-level .status.result; successful runs only set…
Medium severity examples/​fibey-custom-agent-demo/​build-images.md — .status.result is not a Task field, so this verification output is always null, even after a…

Comment thread examples/fibey-custom-agent-demo/README.md Outdated
Comment thread examples/fibey-custom-agent-demo/build-images.md Outdated
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 9, 2026 00:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The example, safety checks, tests, and documentation align with the external harness v2 contracts.

Review tier: Balanced
Findings: None

Issues resolved since last review (2)
Severity Finding
Medium severity examples/​fibey-custom-agent-demo/​build-images.md — .status.result is not a Task field, so this verification output is always null, even after a… View resolved comment
Medium severity examples/​fibey-custom-agent-demo/​README.md — TaskStatus has no top-level .status.result; successful runs only set… View resolved comment

Copilot AI review requested due to automatic review settings September 11, 2026 20:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Post-create read failures need safe guidance, and tests must validate the actual Task manifest through runtimeRef compatibility checks.

Get a fresh assessment by requesting another Copilot review.

Review tier: Balanced
Findings: 1 Medium severity

Open findings (1)

Comment thread examples/fibey-custom-agent-demo/switch-backend.sh Outdated
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 11, 2026 21:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

It combines core settlement recovery behavior with externally hosted deployment paths requiring final human validation.

Review tier: Balanced
Findings: None

Resolved findings (1)
Previously missed findings (1)

In code that hasn't changed since last review

Low severity Capitalize AgentKitfile consistently

examples/​fibey-custom-agent-demo/​build-images.md:208

Use the product’s established AgentKitfile capitalization, consistent with the surrounding AgentKit terminology and upstream documentation.

@sozercan

Copy link
Copy Markdown
Member Author

@microsoft-github-policy-service rerun

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 13, 2026 04:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed implementation is internally consistent, addresses prior feedback, and includes focused regression coverage.

Review tier: Balanced
Findings: None

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 13, 2026 05:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Runtime recovery, concurrency, and external Foundry integration warrant final human review despite strong targeted coverage.

Review tier: Balanced
Findings: None

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copilot AI review requested due to automatic review settings September 13, 2026 05:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation and coverage are consistent with the harness-v2 runtime, recovery, and security contracts.

Review tier: Balanced
Findings: None

Copilot AI review requested due to automatic review settings September 14, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Distributed recovery semantics and cross-repository runtime deployment contracts warrant final human review.

Review tier: Balanced
Findings: None

@sozercan Sertaç Özercan (sozercan) added this to the 0.2.0 milestone Sep 14, 2026
@sozercan
Sertaç Özercan (sozercan) merged commit 7c8bdf8 into main Sep 14, 2026
38 checks passed
@sozercan
Sertaç Özercan (sozercan) deleted the feat/fibey-v2-demo branch September 14, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants