You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace best-effort E2E AfterSuite cleanup with recorded evidence, split out of #589. Nothing in the approval work depends on it.
Every Task still present at AfterSuite, plus the specs that opt into the harness, gets an observer finalizer, is deleted with a UID precondition, and has its controller cleanup receipt recomputed and released before the suite ends. Kind teardown is recorded the same way, and a jq gate fails CI when any boundary is unproved. The Gateway lane verifies terminal retention before fixture teardown, and ephemeral clusters run the full undeploy and namespace delete before kind delete.
Compared with the original branch, the two build-tagged unit-test files for the test helpers (1,063 lines that only ran inside the live lane) are dropped; the live specs exercise the same helpers.
Cost to be aware of: the Gateway lane now waits the real retention loop, so its go test timeout moves from 30 to 55 minutes and the job from 60 to 75.
Validation: go vet -tags e2e ./test/e2e/, bash -n on the scripts, actionlint on the three workflows, make lint-fix.
Replace best-effort AfterSuite cleanup with recorded evidence. Every
Task gets an observer finalizer, is deleted with a UID precondition, and
has its controller cleanup receipt recomputed and released before the
suite ends. Kind teardown is recorded the same way, and a jq gate fails
CI when any boundary is unproved.
The Gateway lane now verifies terminal retention before fixture
teardown, and ephemeral clusters run the full undeploy and namespace
delete before kind delete.
Mark the evidence record as receipt-required as soon as the observed
Task carries a runtime session identity, so an admitted Task that loses
its execution status during deletion fails closed instead of passing as
a non-ACP Task.
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Remove stale ephemeral cleanup documentation and workflow setting
test/e2e/e2e_suite_test.go:302
This now performs normal per-resource cleanup for all lanes, but website/docs/development/testing.md:212 still states that E2E_EPHEMERAL_CLUSTER skips that cleanup, and the Gateway workflow still exports the now-unused variable. Update the documentation and remove the stale setting so operators do not rely on behavior that no longer exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace best-effort E2E AfterSuite cleanup with recorded evidence, split out of #589. Nothing in the approval work depends on it.
Every Task still present at AfterSuite, plus the specs that opt into the harness, gets an observer finalizer, is deleted with a UID precondition, and has its controller cleanup receipt recomputed and released before the suite ends. Kind teardown is recorded the same way, and a jq gate fails CI when any boundary is unproved. The Gateway lane verifies terminal retention before fixture teardown, and ephemeral clusters run the full undeploy and namespace delete before
kind delete.Compared with the original branch, the two build-tagged unit-test files for the test helpers (1,063 lines that only ran inside the live lane) are dropped; the live specs exercise the same helpers.
Cost to be aware of: the Gateway lane now waits the real retention loop, so its
go testtimeout moves from 30 to 55 minutes and the job from 60 to 75.Validation:
go vet -tags e2e ./test/e2e/,bash -non the scripts,actionlinton the three workflows,make lint-fix.