Add as_slice and as_mut_slice methods for keys and values of DenseSlotMap#134
Closed
Swiiz wants to merge 3 commits intoorlp:masterfrom
Closed
Add as_slice and as_mut_slice methods for keys and values of DenseSlotMap#134Swiiz wants to merge 3 commits intoorlp:masterfrom
Swiiz wants to merge 3 commits intoorlp:masterfrom
Conversation
|
Ill also link #81 which we've been using as a patch in the past 4 years to achieve this goal as well. |
add keys_values_as_mut_slices method for DenseSlotMap
Closed
Owner
|
Superseded by #140. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DenseSlotMap store all values contiguously, these proposed methods provide direct access to the underlying Vec data as slices, allowing for more efficient operations that can be performed on contiguous memory blocks. This is particularly useful for FFI (Foreign Function Interface).
Open issues: #114 and #131.