Skip to content

Conversation

@David-Wobrock
Copy link
Contributor

Document how to set up a LINE social sign-in.

Related Issue or Design Document

Relates to ory/kratos#4240

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@David-Wobrock
Copy link
Contributor Author

Thanks @vinckr for the patch 🙏

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@alnr
Copy link
Contributor

alnr commented May 14, 2025

Hey @David-Wobrock !
ory/kratos#4240 was just merged to master. Would you mind rebasing this PR? We've done some restructuring to the docs in the meantime. Thank you!

@David-Wobrock David-Wobrock force-pushed the feat/document-line-social-signin branch from e43bb18 to 14dba14 Compare May 15, 2025 09:59
@David-Wobrock
Copy link
Contributor Author

Hey @David-Wobrock ! ory/kratos#4240 was just merged to master. Would you mind rebasing this PR? We've done some restructuring to the docs in the meantime. Thank you!

Sure! Conflicts are fixed ✔️ I pushed the changes :)

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
didnt test the provider

@David-Wobrock
Copy link
Contributor Author

didnt test the provider

We have been running a fork of Kratos in production with ory/kratos#4240 for a while now.
I can confirm it works 😁

With a configuration like:

                - id: line
                  provider: line
                  auth_url: https://access.line.me/oauth2/v2.1/authorize
                  issuer_url: https://access.line.me
                  mapper_url: file:///etc/config/line_mapping.jsonnet
                  token_url: https://api.line.me/oauth2/v2.1/token
                  client_id: placeholder-filled-by-env-config
                  client_secret: placeholder-filled-by-env-config
                  scope:
                    - email
                    - openid
                    - profile

@vinckr
Copy link
Member

vinckr commented May 15, 2025

playwright tests are failing it seems because we are coming from an repo outside of ory org.
but i think its fine, once the upstream is released we can merge even though they fail, this doesn't touch the code examples.

@alnr alnr merged commit 5f61b7e into ory:master May 21, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants