-
Notifications
You must be signed in to change notification settings - Fork 460
feat: document LINE social sign-in provider #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document LINE social sign-in provider #2006
Conversation
08eea37 to
3234dbf
Compare
3234dbf to
f3ab52c
Compare
f3ab52c to
1dbe734
Compare
|
Thanks @vinckr for the patch 🙏 |
d13c654 to
f345a6e
Compare
vinckr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
f345a6e to
e43bb18
Compare
|
Hey @David-Wobrock ! |
e43bb18 to
14dba14
Compare
Sure! Conflicts are fixed ✔️ I pushed the changes :) |
vinckr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
didnt test the provider
We have been running a fork of Kratos in production with ory/kratos#4240 for a while now. With a configuration like: |
|
playwright tests are failing it seems because we are coming from an repo outside of ory org. |
Document how to set up a LINE social sign-in.
Related Issue or Design Document
Relates to ory/kratos#4240
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments