Added multiselect to ListView#40
Conversation
|
Do you want changes to be made to try to satisfy the CodeClimate CI? |
Don't really have to worry about those unless you're met with a bunch of 'em. But you can look at it if you want to. |
|
In this case I don't believe the changes are necessary, the "complexity" really isn't all that complex in my opinion. Is there anything else you want to see out of this PR? |
andersevenrud
left a comment
There was a problem hiding this comment.
I haven't found the time to test this myself, but from a code standpoint, this looks OK to me.
I could publish this with a @next tag on npm if you want. I wanna test this myself, but don't think I really have enough time to thoroughly do it until Thu/Fri.
I went ahead and did that. So |
|
I'd hold up closing related issued until it's published into |
Adds some additional functionality to the existing #33, which is meant to close out #32.
This implementation has more feature-parity with typical desktop file manager applications in that the
ctrlandshiftkeys now have separate useful functionality. Thectrlkey allows for the selection of multiple individual files, whereas theshiftkey allows for a selection of a range of files.