Skip to content

OSAC-4808: Classify substantive EP changes as ask #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ItzikEzra-rh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSAC-4808: Classify substantive EP changes as ask #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,13 @@ reviews:
Eligible file categories:
- Documentation (*.md, docs/**) excluding review-policy files
(AGENTS.md, CLAUDE.md, CONTRIBUTING.md — these govern review
behavior and are not trivial)
behavior and are not trivial) and substantive PRDs or design
documents in osac-project/enhancement-proposals. A change there is
substantive when it adds, removes, or changes product requirements,
scope, user stories, acceptance criteria, interfaces, architecture,
security, compatibility, risks, dependencies, or design decisions.
Typo, formatting, link, and other meaning-preserving corrections
remain eligible for Ship.
- CI configuration — comment and formatting changes only to
existing files under .github/workflows/** and
.github/actions/** (any semantic change — including run,
Expand Down Expand Up @@ -119,6 +125,8 @@ reviews:
- Review-policy files (AGENTS.md, CLAUDE.md,
CONTRIBUTING.md)
- Hand-edited generated files
- PRDs or design documents in
osac-project/enhancement-proposals

Typical Show changes: test additions or fixes, CLI help text,
logging improvements, Helm chart doc annotations, single-
Expand All @@ -145,6 +153,15 @@ reviews:
- The change modifies .coderabbit.yaml (review policy)
- The change modifies review-policy files (AGENTS.md,
CLAUDE.md, CONTRIBUTING.md)
- In osac-project/enhancement-proposals, the change
adds, removes, or changes a PRD or design document's product
requirements, scope, user stories, acceptance criteria, interfaces,
architecture, security, compatibility, risks, dependencies, or
design decisions. These documents require human review because
approving them establishes product or architecture direction, even
though the diff itself has no immediate runtime impact. Typo,
formatting, link, and other meaning-preserving corrections are not
substantive.
- The change hand-edits generated files rather than pure
regeneration
- You are uncertain about the appropriate risk level
Expand Down
Loading