Skip to content

NO ISSUE: Enable Slack notify on scheduled E2E failures - #753

Open
minmzzhang wants to merge 1 commit into
osac-project:mainfrom
minmzzhang:fix/e2e-scheduled-slack-notify
Open

NO ISSUE: Enable Slack notify on scheduled E2E failures#753
minmzzhang wants to merge 1 commit into
osac-project:mainfrom
minmzzhang:fix/e2e-scheduled-slack-notify

Conversation

@minmzzhang

@minmzzhang minmzzhang commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass notify-on-failure: ${{ github.event_name == 'schedule' }} from osac full-install callers (CaaS, VMaaS, BMaaS)
  • Matches osac-test-infra caller behavior so scheduled failures post to #osac-ci

Test plan

  • Merge and wait for next scheduled CaaS full-install failure (or temporarily break a scheduled run)
  • Confirm Notify Slack on failure step runs (not skipped) and message lands in #osac-ci

CI

  • CaaS, VMaaS, and BMaaS scheduled full-install workflows now set notify-on-failure to true.
  • Other event types set notify-on-failure to false.
  • Scheduled failures now send Slack notifications to #osac-ci, consistent with the osac-test-infra caller.

Compatibility

  • No API, runtime, database, authentication, deployment, test, or documentation changes.
  • No backward-compatibility impact outside scheduled CI notification behavior.

Risk classification

  • risk:ship: The change is limited to CI workflow configuration and enables notifications only for scheduled failures.
  • It does not alter product behavior, interfaces, credentials, or deployment logic.

Scheduled osac full-install callers omitted notify-on-failure, so
osac-test-infra skipped Slack on failure.

Assisted-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Min Zhang <minzhang@redhat.com>
@openshift-ci
openshift-ci Bot requested review from carbonin and maorfr September 4, 2026 22:08
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: minmzzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Sep 4, 2026
@minmzzhang minmzzhang changed the title Enable Slack notify on scheduled E2E failures NO ISSUE: Enable Slack notify on scheduled E2E failures Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 05a049d3-8c10-4c50-93ba-97b27259ed14

📥 Commits

Reviewing files that changed from the base of the PR and between 79d0508 and 25479fe.

📒 Files selected for processing (3)
  • .github/workflows/e2e-bmaas-full-install.yml
  • .github/workflows/e2e-caas-full-install.yml
  • .github/workflows/e2e-vmaas-full-install.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The BMaaS, CaaS, and VMaaS full-install workflows now enable failure notifications for scheduled runs and disable them for other event types.

Changes

Installation workflow notifications

Layer / File(s) Summary
Schedule-based notification inputs
.github/workflows/e2e-bmaas-full-install.yml, .github/workflows/e2e-caas-full-install.yml, .github/workflows/e2e-vmaas-full-install.yml
Each reusable workflow call sets notify-on-failure to true for scheduled runs and false for other events.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 25479

Scheduled full-install failures for BMaaS, CaaS, and VMaaS will now notify #osac-ci, while non-scheduled runs remain unchanged. The change is ready to merge.

Suggested labels: risk:show

Suggested reviewers: eliorerz

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed PASS. The PR adds only notify-on-failure: ${{ github.event_name == 'schedule' }} to three workflows. The added lines contain no API keys, tokens, passwords, private-key material, credentials, embedd…
No-Weak-Crypto ✅ Passed PASS: The parent diff contains only three additions of notify-on-failure: ${{ github.event_name == 'schedule' }} in GitHub Actions workflow callers. The added lines contain no MD5, SHA1, DES, RC4, 3…
No-Injection-Vectors ✅ Passed PASS: The PR changes only three reusable-workflow caller inputs. Each added line is notify-on-failure: ${{ github.event_name == 'schedule' }}. The diff adds no SQL concatenation, shell execution, ev…
Container-Privileges ✅ Passed PASS. The pull request adds only notify-on-failure: ${{ github.event_name == 'schedule' }} to three GitHub Actions reusable-workflow caller blocks. The added lines do not set privileged, hostPID
No-Sensitive-Data-In-Logs ✅ Passed PASS: The commit adds only notify-on-failure: ${{ github.event_name == 'schedule' }} to three reusable-workflow callers. It adds no logging, secret interpolation, or sensitive-data output. The refer…
Ai-Attribution ✅ Passed The PR uses AI assistance, as shown by commit 25479fe. The commit includes the required Assisted-by: Cursor <cursoragent@cursor.com> trailer. It does not include a Co-Authored-By trailer for the A…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: enabling Slack notifications for scheduled E2E failures. The "NO ISSUE" prefix is unnecessary but does not make the title misleading.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

E2E on CodeRabbit approval

CodeRabbit APPROVED — starting expensive e2e (PR run replay).

  • Started: 3/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant