NO ISSUE: Enable Slack notify on scheduled E2E failures - #753
Conversation
Scheduled osac full-install callers omitted notify-on-failure, so osac-test-infra skipped Slack on failure. Assisted-by: Cursor <cursoragent@cursor.com> Signed-off-by: Min Zhang <minzhang@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: minmzzhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe BMaaS, CaaS, and VMaaS full-install workflows now enable failure notifications for scheduled runs and disable them for other event types. ChangesInstallation workflow notifications
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Scheduled full-install failures for BMaaS, CaaS, and VMaaS will now notify Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
E2E on CodeRabbit approvalCodeRabbit APPROVED — starting expensive e2e (PR run replay).
|
Summary
notify-on-failure: ${{ github.event_name == 'schedule' }}from osac full-install callers (CaaS, VMaaS, BMaaS)#osac-ciTest plan
#osac-ciCI
notify-on-failuretotrue.notify-on-failuretofalse.#osac-ci, consistent with the osac-test-infra caller.Compatibility
Risk classification
risk:ship: The change is limited to CI workflow configuration and enables notifications only for scheduled failures.