docs: allow the export_test.go alias - #161
Merged
Merged
Conversation
The strict form here said export_test.go may expose setters only, never an alias. That contradicts the corrected capability, and the pattern it banned is idiomatic Go used by twenty-two standard library packages. The concern was always about a test re-covering what the caller's test already reaches, and about where a seam sits. Both say that now. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 184 184
Lines 6359 6359
=========================================
Hits 6359 6359 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows osapi-io/specs#80, which corrected the
export_test.gorequirement.This repository stated the strict form in two places — the test file conventions and done-definition item 6 — saying
export_test.gomay expose setters only and nevervar ReadX = readXaliases.That contradicts the corrected capability. The alias is idiomatic Go; twenty-two standard library packages use it, and this repository has four of its own (
BytesToString,DefaultUname,ReadInterfaces,DefaultInterfaceAddrs) that the strict rule made violations of its own documentation.Both passages now state what the rule was always protecting:
just md-fmt-checkpasses.🤖 Generated with Claude Code