refactor(just)!: remove the bats and docker modules - #56
Merged
Conversation
BREAKING CHANGE: bats.just, bats.mod.just, docker.just and docker.mod.just are removed. No repository fetches either. No .bats file exists in the organization, and docker's recipes were never invoked -- images are published by goreleaser, and its dockerfile default named a file the only repository loading it does not have. Also rewrites the README's usage section, which still taught the shim pattern with mod? and .mod.just and used bats as its example. Four of the five remaining modules are flat; the example now shows import?, prefixed recipes, and overriding a default. Applies converge-justfile-consumption tasks 1.3 and 1.4. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING:
bats.just,bats.mod.just,docker.just, anddocker.mod.justare removed. No repository fetches either, so nothing breaks.
bats— no repository fetches it, and no.batsfile exists anywhere inthe organization. It appeared only in this README, as the usage example.
docker— nothing invoked its recipes. Images are published by goreleaser,and its
dockerfiledefault namedDockerfile.local, which the one repositoryloading it does not have.
Per specs#50: a module no repository
fetches is removed rather than maintained.
The README was teaching the old pattern
Its usage section still showed
modwith.mod.justshims, and usedbatsasthe example — the pattern four of the five remaining modules no longer use. It
now shows
import?, prefixed recipe names, and how to override a module defaultwith
allow-duplicate-variables.Also removed the inline
docker.justsection and updated the dependency anddocumentation examples, which still used
go::depsandbats::test.Applies
converge-justfile-consumptiontasks 1.3 and 1.4.🤖 Generated with Claude Code