chore: float go so local matches continuous integration - #451
Merged
Conversation
.mise.toml declared go = "1.25" while every workflow sets go-version: stable. That is a pin on one path and a float on the other, and the two have already diverged: CI builds with 1.26.6, mise supplies 1.25.7. gofumpt output can change between toolchains, so the divergence surfaces as a check failing on a file nobody edited. Nothing bumps .mise.toml, so per the requirement both paths track the latest release rather than one side holding a pin the other never sees. just test passes on 1.26.6. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 484 484
Lines 24935 24935
=======================================
Hits 24921 24921
Misses 14 14 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.mise.tomldeclaredgo = "1.25"while every workflow setsgo-version: stable. That is a pin on one path and a float on the other, which therepo-standardsrequirement Every path provisions the same tool version forbids:This is not hypothetical
The two paths have already diverged:
.mise.toml(go = "1.25")go-version: stable)Verified from a CI log:
Setup go version spec stable→go version go1.26.6 linux/amd64.So every contributor has been building and formatting with 1.25.7 while CI checks the result with 1.26.6.
gofumptoutput can change between toolchains, and that is exactly the failure the requirement describes — a check failing on a file nobody edited.Why float rather than pin CI
The requirement gives the rule:
Nothing bumps
.mise.toml— Dependabot has no ecosystem for it. So both paths track latest, which meansgo = "latest"locally rather than pinning CI backwards to 1.25.Verification
just testpasses on 1.26.6 — lint, unit tests, and the coverage gate.🤖 Generated with Claude Code