chore: tick the react module conversion - #36
Merged
Conversation
Task 1.5 is complete: osapi-justfiles#44 converts react to a flat module with its own directory and README, and osapi#436 updates both consuming justfiles. 2.5 stays open. osapi's react consumption is done, but it still loads go, docs, just and docker as shims. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
converge-justfile-consumptiontask 1.5 is complete.reactbecomes a flat module in its own directory with a README, shim deleted, inline section removed from the root README and listed in the converted-modules table alongsidemdTask 2.5 stays open: osapi's react consumption is done, but it still loads
go,docs,just, anddockeras shims.The conversion was forced rather than chosen.
osapihad forked and committedreact.mod.justto change one path, and the env-var approach could not replace it —env()resolves against the process environment at parse time, so a consumer cannot set it from its own justfile. A flat import shares one scope, so the consumer declaresreact_dirand the module reads it.🤖 Generated with Claude Code