feat: require a suite to be named for its surface - #78
Merged
Conversation
Applying the change removed the suite naming convention from four repositories while the capability did not state it. All five follow it: 506 of 506 public suites, and internal suites everywhere except integration smoke suites, which are a different thing. Resolves the open question by answering it with what applying showed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying
specify-go-code-standardsrevealed a gap in it.Section 2 removed the suite naming convention —
*_public_test.go→{Name}PublicTestSuite,*_test.go→{Name}TestSuite— from four repositories'CONTRIBUTING.md. The capability does not state it. I had parked it as an open question indesign.mdand then deleted it from the repositories anyway, so the rule would have landed nowhere.It is universal:
*PublicTestSuite506 of 506. Internal suites follow
*TestSuiteeverywhere except osapi'stest/integration/smoke suites, which drive a built binary rather than exercising a package — a different thing, and the requirement says so rather than forcing them into the pair.The open question in
design.mdis resolved with what applying showed, rather than with the argument about whether the capability was already long enough.🤖 Generated with Claude Code