Skip to content

docs: record go-code-standards progress #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
retr0h merged 1 commit into from
Aug 16, 2026
+10 −8
Merged

docs: record go-code-standards progress #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions openspec/changes/specify-go-code-standards/tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,20 @@

## 2. Point each repository at the capability

- [ ] 2.1 `gohai` — `CONTRIBUTING.md` keeps its collector-specific conventions
- [ ] 2.2 `nats-client` — `CONTRIBUTING.md`
- [ ] 2.3 `nats-server` — `CONTRIBUTING.md`
- [ ] 2.4 `osapi-orchestrator` — `CONTRIBUTING.md`
- [x] 2.1 `gohai` — `CONTRIBUTING.md` keeps its collector-specific conventions
- [x] 2.2 `nats-client` — `CONTRIBUTING.md`
- [x] 2.3 `nats-server` — `CONTRIBUTING.md`
- [x] 2.4 `osapi-orchestrator` — `CONTRIBUTING.md`
- [ ] 2.5 `osapi` — `CLAUDE.md` drops `Code Standards`, and the conventions
duplicated into `development.md` and `testing.md` resolve to one source

## 3. Verification

- [ ] 3.1 Confirm no `types.go` contains a function
- [ ] 3.2 Confirm no repository holds a generically named file
- [ ] 3.3 Confirm every test package uses a table-driven suite
- [x] 3.1 Confirm no `types.go` contains a function
- [x] 3.2 Confirm no repository holds a generically named file
- [x] 3.3 Confirm every test package uses a table-driven suite
- [ ] 3.4 Confirm no mock is hand-written where an interface is mocked
- [ ] 3.5 Confirm no `export_test.go` exposes an alias to an unexported function
- [ ] 3.5 Confirm no `export_test.go` exposes an alias to an unexported
function. Ten exist — four in `gohai`, which states the rule, and six in
`osapi`. Eleven call sites depend on them
- [ ] 3.6 Confirm no shared convention is stated in two places