chore: record the CONTRIBUTING standardization - #91
Merged
Conversation
All five Go repositories now state the shared conventions in full, under the section order repo-standards fixes. Verified by hashing: the Code standards and Test file conventions blocks are byte-identical in all five, and the only capitalized heading left is Claude Code, a proper noun the requirement exempts. The two NATS libraries omit Project structure, which the requirement permits where a repository has nothing to say under a middle section. Also reconciles specify-go-code-standards. Its tasks 2.2 to 2.4 are satisfied by the standardization, and 3.6 is recorded as superseded: it asked that no shared convention be stated twice, and the rescope decided the opposite -- stated everywhere it binds, identically, because a repository has to be readable on its own. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records what landed across the five Go repositories, and reconciles the tasks that described the superseded direction.
Result
All five
CONTRIBUTING.mdfiles now state the shared conventions in full, under the section orderrepo-standardsfixes:Verified by hashing, not by reading:
Code standardsbody340c266eaf15Test file conventions28bb2b430230A difference in wording would now mean a difference in rule.
nats-clientandnats-serveromitProject structure— permitted, since the requirement says a repository with nothing to say under a middle section omits it rather than padding it. The only capitalized heading left anywhere is### Claude Code, a proper noun the requirement exempts. No repository lists linters in prose any more.Landed as osapi-io/gohai#164, osapi-io/nats-client#133, osapi-io/nats-server#94, osapi-io/osapi-orchestrator#77, osapi-io/osapi#452.
Reconciles
specify-go-code-standardsTasks 2.2–2.4 are satisfied by the standardization. Task 3.6 — "confirm no shared convention is stated in two places" — is recorded as superseded: the rescope decided the opposite. A shared convention is now stated in every repository it binds, identically, because a repository has to be readable on its own. What 3.6 was aimed at (copies that disagree) is what
repo-standardsnow forbids.Still open
rescope-go-code-standardssection 5 — the three hand-written mocksspecify-go-code-standards3.4 and 3.5 — the same mocks, and theexport_test.goauditjust test— 13 passed, 0 failed.🤖 Generated with Claude Code