Set the language server to the release version 0.1.0 - #8
Merged
Conversation
The language server was the only component still on a snapshot version, and release-server.yml refuses to publish one. Drop -SNAPSHOT so an ls-v0.1.0 tag can be cut alongside the extension and osate-cli, which are already at 0.1.0. Tycho keeps the Maven and OSGi versions in lockstep: validate-version wants .qualifier for a snapshot but exact equality for a release, so both manifests have to lose .qualifier in the same commit or the build fails at validate before compiling anything. The published bundle becomes org.osate.aadl.ls_0.1.0.jar. Move the repository-root aggregator too. Its version is reported as tooling.version in build-provenance.properties, which is attached to the ls-v* release, and a released 0.1.0 should not ship provenance claiming -SNAPSHOT. vscode-extension/pom.xml inherits from the aggregator, so its parent reference moves with it. Record both rules in RELEASING.md, along with the post-release return to a snapshot version, so the next person does not have to rediscover why eight lines move together. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language server was the only component still on a snapshot version, and
release-server.ymlrefuses to publish one, so anls-v0.1.0tag cannot be cutuntil this lands.
osate-cliand the VS Code extension are already at0.1.0.Tycho keeps the Maven and OSGi versions in lockstep:
validate-versionrequires.qualifierfor a snapshot but exact equality for a release version, so bothMANIFEST.MFfiles lose.qualifierin the same commit. Leaving them behindfails the build at
validatebefore anything compiles. The published bundlebecomes
org.osate.aadl.ls_0.1.0.jarand the p2 archiveorg.osate.aadl.ls.repository-0.1.0.zip.The repository-root aggregator moves too, because its version is reported as
tooling.versioninbuild-provenance.properties, which is attached to thels-v*release — a released0.1.0should not ship provenance claiming-SNAPSHOT.vscode-extension/pom.xmlinherits from the aggregator, so itsparent reference has to move with it.
RELEASING.mdgains the two rules that are not derivable from the workflows:which eight lines move together when the server version changes, and the
post-release return to a snapshot version so development builds stay
timestamp-qualified and p2 can tell one local rebuild from the next.
Verification
Local
mvn -f aadl-language-server/pom.xml clean verify -Dtycho.localArtifacts=ignorepasses;
AllTestsreports 35 tests, 2 skipped, 0 failures, 0 errors, and thebuilt bundle is
org.osate.aadl.ls_0.1.0.jarwith no timestamp qualifier.Once this is merged,
ls-v0.1.0,vscode-v0.1.0-pre, andosate-cli-v0.1.0will all be tagged on the merge commit.
🤖 Generated with Claude Code