Validate Behavior Annex communication actions and subprogram call signatures 🤖

[lwrage]

Summary

BA communication actions and subprogram calls lack complete AS5506/3 Rev. A D.5/D.6 category, direction, signature, and parameter validation. The grammar accepts a generic reference and expression list; port-send translation silently uses only the first expression; the type checker does not validate SubprogramCallAction signatures.

Reproduction

This issue comes from the source audit in ba/doc/conformance.md; no additional runtime reproduction was performed. The incomplete paths are visible in toCommunicationAction, getFormalParameters, and checkBasicAction.

Expected behavior

Validate that communication targets support the selected operation and that subprogram actuals match all required formal features in count, order, direction, and type. Reject extra port-send values instead of discarding them.

Relevant code

• ba/org.osate.xtext.aadl2.ba/src/org/osate/xtext/aadl2/ba/BehaviorAnnex.xtext — CommunicationAction.
• ba/org.osate.xtext.aadl2.ba/src/org/osate/xtext/aadl2/ba/translation/DeclarativeToStrictTranslator.java — toCommunicationAction and getFormalParameters.
• ba/org.osate.ba/src/org/osate/ba/analyzers/AadlBaTypeChecker.java — checkBasicAction.
• Related historical issue: Behavior annex plugin throws an error if subprogram call action refers to something else than a subprogram classifier #2200.

[lwrage]

Declarative versus instance boundary

Communication target category and direction, subprogram parameter count and order, and the in/out shape of each actual are structural checks and can remain in source validation.

Per-actual type compatibility is only declarative when it uses property-independent classifier information. If it derives representation, element type, rank, extent, range, or another type fact from Data Model properties, contained property associations can change the answer for a particular port, parameter, access, or component instance. Those comparisons need the instance-side BA checking path. Tests should separate structural signature errors from property-derived type mismatches.