Enforce Behavior Annex dispatch protocol and trigger compatibility rules 🤖

[lwrage]

Summary

BA validation does not implement the complete AS5506/3 Rev. A D.4 compatibility matrix between Dispatch_Protocol and dispatch-trigger conditions, or all naming/category and core dispatch/freeze consistency rules.

The checker has selected timeout and stop branches, while dispatch and frozen-port syntax resolve through generic references.

Reproduction

This issue comes from the source audit in ba/doc/conformance.md; no additional runtime reproduction was performed.

Expected behavior

Validate every D.4 protocol/trigger matrix row, legal feature directions and categories, dispatch trigger property restrictions, and frozen-port consistency. Diagnostics should identify the incompatible trigger or property.

Relevant code

• ba/org.osate.ba/src/org/osate/ba/analyzers/AadlBaLegalityRulesChecker.java — D.4 timeout checks.
• ba/org.osate.ba/src/org/osate/ba/analyzers/AadlBaSemanticRulesChecker.java — stop check.
• ba/org.osate.xtext.aadl2.ba/src/org/osate/xtext/aadl2/ba/BehaviorAnnex.xtext — dispatch and frozen references.

[lwrage]

Instance-model implementation boundary

The protocol/trigger matrix cannot be checked soundly from the declarative classifier whenever the answer depends on Dispatch_Protocol, Dispatch_Trigger, Period, or another effective property value. A contained property association can assign different values to two instances of the same component classifier.

The current D.4 checker already illustrates the problem by calling PropertyUtils.findPropertyExpression(_baParentContainer, Dispatch_Protocol) and getIntValue(_baParentContainer, Period), where _baParentContainer is the declarative classifier supplied by BehaviorAnnexValidator.

Structural parts of this issue, including trigger syntax, referenced-feature category, and direction, can remain in source validation. Every protocol or property-value comparison needs an instance-side BA validation or analysis pass over the corresponding ComponentInstance and FeatureInstance. A regression should instantiate the same classifier twice with a contained property override on only one instance and require different results.