Detect Behavior Annex execution states that can remain blocked 馃 - #3236
Merged
Merged
Conversation
Model execution states with no outgoing transition and with only statically false execute conditions, and assert the missing D.3 diagnostics. Include positive controls for runtime-dependent, true, unconditional, and otherwise conditions to keep the analysis conservative.
Implement the D.3 consistency check for execution states whose outgoing condition disjunction is definitely false. Fold Boolean literal guards conservatively, accepting runtime-dependent and unsupported conditions when blocking cannot be proven. Update conformance documentation, characterization baselines, and existing positive fixtures so the broader Behavior Annex suite reflects the new diagnostic without obscuring their original intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3185
Cause
The active Behavior Annex consistency-checking path did not enforce D.3(C3), so an execution state could have no outgoing transition, or only statically false execute conditions, without a diagnostic.
Correction
Add a D.3(C3) consistency check that folds Boolean literal guards with
not,and,and then,or,or else, andxor. It reports only when the outgoing disjunction is definitely false. Unconditional andotherwisetransitions satisfy the rule, while runtime-dependent expressions, relations, non-value conditions, and unsupported forms remain conservatively accepted.Update the conformance record, characterization baselines, and existing positive fixtures affected by the new diagnostic.
Regression coverage
Issue3185Testuses external AADL fixtures to verify:otherwiseconditions remain accepted.The regression commit precedes the production-fix commit.
Validation
Issue3185Test: 3 tests, 0 failures, 0 errors, 0 skipped.-T5and-Dtycho.localArtifacts=ignore: 143 projects and 1,640 tests, 0 failures, 0 errors, 0 skipped.git diff --check: clean.Dependencies
None. The branch is based directly on current
origin/master.Residual risk
The check intentionally does not attempt a general symbolic proof. Conditions whose truth depends on runtime values or unsupported expression forms are treated as unknown to avoid false positives.