Include workspace property sets in the property filter dialog 馃 - #3240
Merged
Merged
Conversation
Replace the property-set filter characterization with a minimal SWTBot regression using two assigned workspace property sets and a contributed set. Validate the fixture before checking that Select All preserves workspace properties. Cover the requested group labels and order, an unimported workspace set, individual and group selection, reopening, and cancellation. Both tests fail on the existing dialog for the reported behavior.
Read workspace property sets from the Xtext index whenever the property view opens its filter dialog. Offer them in a Workspace Property Sets group immediately after the renamed Predeclared Property Sets group. Use the same URI-based selection and checkbox propagation for workspace and contributed sets so Select All restores workspace properties and individual selections survive reopening. Fixes #3234.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3234
Confirming the property-set filter dialog previously hid workspace property sets because the dialog only offered contributed sets. The dialog now reads workspace property sets from the Xtext index and makes them individually selectable under Workspace Property Sets, immediately after Predeclared Property Sets. The predeclared group label no longer contains underscores.
Issue3234Testreplaces the previous characterization with a separate, validated AADL model project. It reproduces workspace properties disappearing after Select All, then verifies the fix, group ordering, an unimported workspace set, individual and group checkboxes, reopening, and cancellation. The branch contains the regression commit followed by the production fix.Validation
The regression failed before the fix with both workspace sets missing from the view and the old underscored group label. After the fix, both regression tests passed:
The clean root reactor passed all 144 modules and 1,690 tests, including 53 UI tests, with zero failures, errors, or skips:
Scope and dependencies
Targets
masterwith no dependencies on unmerged PRs. Risk is limited to property-view filter selection and presentation; the change uses the existing URI-based filter and checkbox behavior, and workspace discovery relies on the Xtext index.