Protect shared values in the AADL Property Values view 馃 - #3241
Merged
Merged
Conversation
Exercise shared contained property values through the AADL Property Values view using a separate, validated AADL model project. Verify sibling-value preservation, shared scalar and nested-value editability, and safe removal after Make Local or Make Local Contained. Include the EMV2 UI service provider in the UI test runtime so property lookup can load contributed libraries. Before the fix, five of the seven new tests fail, including the loss of the unselected child value; both localization tests and all twelve existing context-menu tests pass.
Use one association-status calculation for the property status column and editability checks. Classify contained associations with multiple applies-to targets as LOCAL_SHARED so Remove and value editing remain disabled for their scalar and nested values. Update the existing context-menu characterization to require localization before removal. All seven Issue3235Test regressions pass, including sibling preservation after both localization actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3235
Removing a shared contained property value from one subcomponent deleted the whole association, including the value on other subcomponents. Use the same association-status calculation for the status column and editability checks, returning
LOCAL_SHAREDwhen an association has multipleapplies totargets. Remove and value editing are now disabled for shared values and their nested entries; Make Local and Make Local Contained remain available.Issue3235Testimports a separate, validated AADL model with two children sharing scalar, record, list, and range values. Seven UI regressions cover sibling-value preservation, shared-value status and rendering, removal enablement, and safe removal after either localization action. The existing context-menu characterization now expects Remove to be disabled. The UI test runtime also includes the EMV2 UI bundle, which supplies the resource service provider needed when property lookup loads contributed EMV2 libraries.Validation
Before the fix, five new regressions failed, including the second child's value becoming empty after Remove on the first child. Both localization regressions and all 12 existing context-menu tests passed.
After the fix, all seven new regressions passed:
The clean 144-module root reactor passed 1,696 tests, including 59 UI tests, with no failures, errors, or skips:
No dependencies on unmerged PRs. The regression commit precedes the production-fix commit. Residual risk is limited to property-view status, rendering, and action enablement; the existing UI suite covers local, inherited, default, modal, and nested property values.