Restrict BA property references to unitless or time values 🤖

[lwrage]

Behavior Annex property references accepted non-time units because validation checked the value representation without enforcing the D.7 unit-category restriction. Check the declared type of referenced properties, constants, and selected record fields, accepting unitless values and AADL_Project::Time_Units and reporting other units at the source reference.

Fixes #3191.

The external issue3191 models exercise integer and real properties, constants, record fields, self and port prefixes, properties without defaults, and a custom units type whose literal is named ms. Before the fix, the negative regression expected nine diagnostics and received none. All three regression tests now pass, including preservation of written time units and symbolic owner/property references. The regression commit precedes the production fix.

Validation on the branch rebased onto current master:

mvn -o -T5 -s releng/osate.releng/settings.xml -Plocal \
  -Dtycho.localArtifacts=ignore -Dpr.build=true -Dsign=false \
  -Dspotbugs=false -Dcodecoverage=false -Djavadoc=false \
  -DfailIfNoTests=false clean install

All 143 reactor projects passed. Surefire reports contain 1,650 tests across 15 bundles, with zero failures, errors, or skips, including 190 BA tests and all three Issue3191Test cases. git diff --check passes.

There are no dependencies on unmerged PRs. The change adds a diagnostic for previously accepted non-time units. Effective instance-value selection remains part of #3229; translation continues to preserve prefixed references symbolically.