Skip to content

Track Xsemantics generated Java and stop Maven regeneration 馃 - #3259

Merged
lwrage merged 1 commit into
masterfrom
3258_track_xsemantics_generated_sources
Sep 18, 2026
Merged

lwrage merged 1 commit into
masterfrom
3258_track_xsemantics_generated_sources

Conversation

@lwrage

@lwrage lwrage commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Fixes #3258

Maven currently deletes ALISA's generated Xsemantics Java during clean and regenerates it during source generation. Track the six existing generated interpreter, type-system, and validator sources so Maven can compile them directly.

Remove the Xsemantics generation configuration, generator dependencies, and clean filesets from the main and experimental GE parent POMs, along with the ALISA and BA plugin declarations that inherit that configuration. Keep ._trace files ignored and update the comment describing the inherited clean fileset.

Validation

Ran from a clean, isolated checkout of the PR commit:

mvn -o -T5 -s releng/osate.releng/settings.xml -Plocal \
  -Dtycho.localArtifacts=ignore -Dpr.build=true -Dsign=false \
  -Dspotbugs=false -Dcodecoverage=false -Djavadoc=false \
  -DfailIfNoTests=false clean install
  • All 143 reactor projects succeeded.
  • Surefire reports contain 1,690 tests across 15 bundles, with zero failures, errors, or skips.
  • This includes all 30 existing AssureTests, which exercise parsing, validation, and assurance evaluation using the models/SimpleControlSystem fixtures.
  • All six generated Java files remained byte-for-byte identical to the committed sources. No Xsemantics generation ran, and the clean checkout built without trace files.
  • Configuration changes pass the whitespace check. Existing generated whitespace is preserved.

Dependencies and risk

Targets master with no dependency on an unmerged PR. The generated Java is unchanged; the maintenance requirement is to regenerate it explicitly in Eclipse and commit the output whenever the .xsemantics definitions change.

Keep the six ALISA generated Java sources in version control while continuing to ignore their trace files. Remove Xsemantics generation plugins, dependencies, and clean filesets so Maven compiles the checked-in output without regenerating or deleting it.

Validated with a clean root-reactor verify using -T5 and AssureTests: all 30 tests passed, and the generated sources remained byte-for-byte unchanged.
@lwrage
lwrage merged commit 9c0fd15 into master Sep 18, 2026
1 check passed
@lwrage
lwrage deleted the 3258_track_xsemantics_generated_sources branch September 18, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve Xsemantics generated Java across Maven builds 馃

2 participants