Track Xsemantics generated Java and stop Maven regeneration 馃 - #3259
Merged
Merged
Conversation
Keep the six ALISA generated Java sources in version control while continuing to ignore their trace files. Remove Xsemantics generation plugins, dependencies, and clean filesets so Maven compiles the checked-in output without regenerating or deleting it. Validated with a clean root-reactor verify using -T5 and AssureTests: all 30 tests passed, and the generated sources remained byte-for-byte unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3258
Maven currently deletes ALISA's generated Xsemantics Java during
cleanand regenerates it during source generation. Track the six existing generated interpreter, type-system, and validator sources so Maven can compile them directly.Remove the Xsemantics generation configuration, generator dependencies, and clean filesets from the main and experimental GE parent POMs, along with the ALISA and BA plugin declarations that inherit that configuration. Keep
._tracefiles ignored and update the comment describing the inherited clean fileset.Validation
Ran from a clean, isolated checkout of the PR commit:
AssureTests, which exercise parsing, validation, and assurance evaluation using themodels/SimpleControlSystemfixtures.Dependencies and risk
Targets
masterwith no dependency on an unmerged PR. The generated Java is unchanged; the maintenance requirement is to regenerate it explicitly in Eclipse and commit the output whenever the.xsemanticsdefinitions change.